-
Notifications
You must be signed in to change notification settings - Fork 715
test: added saved view cleanup to cleanup spec file #9451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Failed to generate code suggestions for PR |
Greptile OverviewGreptile SummaryThis PR adds saved view cleanup functionality to the test cleanup process. The implementation adds three new methods to Key changes:
The implementation follows the established patterns in the codebase for cleanup methods, includes proper error handling, uses the logging framework consistently, and matches the test data patterns found in the codebase. Confidence Score: 5/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant Test as cleanup.spec.js
participant PM as PageManager
participant API as APICleanup
participant Server as OpenObserve API
Test->>PM: pm.apiCleanup.cleanupSavedViews()
PM->>API: cleanupSavedViews()
API->>API: Log "Starting saved views cleanup"
API->>Server: GET /api/{org}/savedviews
Server-->>API: Return {views: [...]}
API->>API: Log "Fetched saved views"
API->>API: Filter views matching patterns:<br/>"streamslog*" or "multistream_view_*"
API->>API: Log "Found saved views matching cleanup patterns"
alt No matching views
API->>API: Log "No saved views to clean up"
API-->>Test: Return
else Has matching views
loop For each matching view
API->>Server: DELETE /api/{org}/savedviews/{view_id}
Server-->>API: Return deletion result
alt Deletion successful (200)
API->>API: deletedCount++
API->>API: Log "Deleted saved view"
else Deletion failed
API->>API: failedCount++
API->>API: Log "Failed to delete saved view"
end
end
API->>API: Log "Saved views cleanup completed"<br/>(total, deleted, failed counts)
API-->>Test: Return
end
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 files reviewed, no comments
6d06e93 to
de7b2ec
Compare
f686e45 to
c5e906a
Compare
c5e906a to
a057eb5
Compare
No description provided.