Skip to content

Conversation

@oasisk
Copy link
Contributor

@oasisk oasisk commented Dec 2, 2025

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

Failed to generate code suggestions for PR

@oasisk oasisk added this to the v0.30.0 milestone Dec 2, 2025
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Dec 2, 2025

Greptile Overview

Greptile Summary

Removes the "Enable Log Patterns Extraction" toggle from the log stream schema settings UI. This is a frontend-only change that hides the enterprise feature toggle from users.

  • Removed the toggle UI element that was conditionally shown for enterprise users (config.isEnterprise === 'true')
  • Cleaned up associated Vue reactive state (enableLogPatternsExtraction ref)
  • Removed loading and saving of the setting from/to the stream settings API
  • The backend still retains the enable_log_patterns_extraction field in stream settings, so existing configurations are preserved

Confidence Score: 5/5

  • This PR is safe to merge - it's a clean removal of a UI feature toggle with no functional impact on the backend
  • The change is minimal and focused: removes a single UI toggle and its associated state management. All references are properly cleaned up. No logic changes or new functionality introduced. The backend field remains intact for backward compatibility.
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
web/src/components/logstream/schema.vue 5/5 Clean removal of the "Enable Log Patterns Extraction" toggle UI and associated reactive state from the stream schema settings component. All references to enableLogPatternsExtraction properly removed from declaration, loading, saving, and return statement.

Sequence Diagram

sequenceDiagram
    participant User
    participant SchemaVue as schema.vue
    participant API as Stream Settings API
    participant Backend as Backend (Rust)

    Note over SchemaVue: Before PR: Toggle visible for Enterprise users
    User->>SchemaVue: Opens stream schema settings
    SchemaVue->>API: GET stream settings
    API-->>SchemaVue: Returns settings (including enable_log_patterns_extraction)
    SchemaVue->>SchemaVue: Displays toggle (if enterprise)
    User->>SchemaVue: Toggles setting
    SchemaVue->>API: POST settings (with enable_log_patterns_extraction)
    API->>Backend: Store setting

    Note over SchemaVue: After PR: Toggle removed
    User->>SchemaVue: Opens stream schema settings
    SchemaVue->>API: GET stream settings
    API-->>SchemaVue: Returns settings (enable_log_patterns_extraction still present)
    SchemaVue->>SchemaVue: Toggle NOT displayed
    Note over Backend: Backend still supports the field for backward compatibility
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

@oasisk oasisk force-pushed the chore--remove-patterns-extractions-settings branch from a9ae43b to a4ac990 Compare December 2, 2025 11:27
@oasisk oasisk merged commit 44c8820 into main Dec 2, 2025
36 of 37 checks passed
@oasisk oasisk deleted the chore--remove-patterns-extractions-settings branch December 2, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants