fix: console error fix for realtime alert #9435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Failed to generate code suggestions for PR |
Contributor
Greptile OverviewGreptile SummaryAdded optional chaining ( Confidence Score: 4/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant RealTimeAlert
participant FilterGroup
participant hasOnlyOneCondition
RealTimeAlert->>FilterGroup: Pass conditions prop
FilterGroup->>FilterGroup: Initialize groups ref with props.group
Note over FilterGroup: props.group might be undefined/null initially
FilterGroup->>hasOnlyOneCondition: Compute property accessed
hasOnlyOneCondition->>hasOnlyOneCondition: Check groups?.value?.items (with optional chaining)
alt items exists
hasOnlyOneCondition->>hasOnlyOneCondition: Filter conditions and subGroups
hasOnlyOneCondition->>hasOnlyOneCondition: Return conditions?.length === 1 && subGroups?.length === 0
else items is undefined
hasOnlyOneCondition->>hasOnlyOneCondition: Return undefined (no error)
end
hasOnlyOneCondition-->>FilterGroup: Result (boolean or undefined)
FilterGroup->>FilterGroup: Use result to disable/enable AND/OR tabs
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Additional Comments (1)
-
web/src/components/alerts/FilterGroup.vue, line 237 (link)logic: Other usages of
groups.value.itemsin methods likeaddCondition,addGroup, andreorderItemsmay also throw errors ifgroups.value.itemsis undefined
1 file reviewed, 1 comment
nikhilsaikethe
force-pushed
the
fix/console-error-realtimealert
branch
from
e3762c0 to
7e67549
Compare
bjp232004
approved these changes
Dec 3, 2025
nikhilsaikethe
force-pushed
the
fix/console-error-realtimealert
branch
from
7e67549 to
408f466
Compare
bjp232004
approved these changes
Dec 3, 2025
nikhilsaikethe
force-pushed
the
fix/console-error-realtimealert
branch
from
408f466 to
7e1430c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.