-
Notifications
You must be signed in to change notification settings - Fork 713
fix: audit #9417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: audit #9417
Conversation
|
Failed to generate code suggestions for PR |
Greptile OverviewGreptile SummaryReplaced
Confidence Score: 2/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant App as Application
participant LN as load_local_node()
participant GIP as get_local_node_ip()
participant LIB as local-ip-address crate
App->>LN: Initialize LOCAL_NODE
LN->>GIP: Get local IP for http/grpc addresses
GIP->>LIB: Call local_ip()
alt Success (IPv4 or IPv6)
LIB-->>GIP: Return IP address
GIP-->>LN: Return IP as string
else Error
LIB-->>GIP: Return error
GIP->>GIP: Log warning
GIP-->>LN: Fallback to "127.0.0.1"
end
LN-->>App: Return Node with addresses
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 files reviewed, 1 comment
|
checked with sample enterprise version of mmdb, download seems to work fine as well as vrl functions |
This brings changes to the MMDB parser logic. Need to test via VRL functions.