-
Notifications
You must be signed in to change notification settings - Fork 713
fix: oss open issues #9413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
fix: oss open issues #9413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eb11734 to
f052576
Compare
Contributor
|
Failed to generate code suggestions for PR |
Contributor
Greptile OverviewGreptile SummaryConditionally hides the delete button when the configuration tab is active in stream settings.
Confidence Score: 5/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant User
participant SchemaComponent as Schema Component
participant ActiveMainTab as activeMainTab State
User->>SchemaComponent: Navigate to Configuration Tab
SchemaComponent->>ActiveMainTab: Set activeMainTab = 'configuration'
ActiveMainTab-->>SchemaComponent: State updated
Note over SchemaComponent: Evaluates v-if="activeMainTab != 'configuration'"
SchemaComponent->>SchemaComponent: Hide Delete Button
User->>SchemaComponent: Navigate to Schema Settings Tab
SchemaComponent->>ActiveMainTab: Set activeMainTab = 'schemaSettings'
ActiveMainTab-->>SchemaComponent: State updated
Note over SchemaComponent: Evaluates v-if="activeMainTab != 'configuration'"
SchemaComponent->>SchemaComponent: Show Delete Button
User->>SchemaComponent: Navigate to Extended Retention Tab
SchemaComponent->>ActiveMainTab: Set activeMainTab = 'redButton'
ActiveMainTab-->>SchemaComponent: State updated
Note over SchemaComponent: Evaluates v-if="activeMainTab != 'configuration'"
SchemaComponent->>SchemaComponent: Show Delete Button
|
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, no comments
0023430 to
3e38f76
Compare
bjp232004
approved these changes
Dec 1, 2025
3e38f76 to
e87aa4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#9381 #9339 #9337