Skip to content

Conversation

@bjp232004
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the ☢️ Bug Something isn't working label Dec 1, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2025

Failed to generate code suggestions for PR

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Dec 1, 2025

Greptile Overview

Greptile Summary

Reverted the explicit pipeline configuration settings from the Kubernetes Helm installation commands. The commands now rely on the openobserve-collector chart's default pipeline configurations instead of overriding them.

Key changes:

  • Removed explicit --set agent.service.pipelines.* configurations from both external and internal cluster commands
  • Removed explicit --set gateway.service.pipelines.* configurations
  • Simplified Helm commands to only configure exporters and their authentication

The revert is clean and returns the configuration to its pre-PR #9312 state, trusting the Helm chart defaults for pipeline setup.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • Clean revert of previous changes with no logic errors. The change simplifies Helm commands by removing explicit pipeline configurations and relying on chart defaults, which is a safer approach for configuration management
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
web/src/components/ingestion/recommended/KubernetesConfig.vue 5/5 Reverted explicit pipeline configurations from Helm commands, relying on chart defaults instead

Sequence Diagram

sequenceDiagram
    participant User
    participant UI as KubernetesConfig.vue
    participant Helm as Helm Chart
    participant K8s as Kubernetes Cluster
    
    User->>UI: View Kubernetes installation instructions
    UI->>User: Display helm commands
    
    Note over UI: Commands now exclude explicit pipeline configs
    
    User->>Helm: Execute helm upgrade --install
    Note over Helm: Sets exporters configuration only
    Note over Helm: Pipeline configs use chart defaults
    
    Helm->>K8s: Deploy openobserve-collector
    K8s->>K8s: Configure pipelines from chart defaults
    K8s-->>User: Collector deployed successfully
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

@bjp232004 bjp232004 merged commit f08d201 into branch-v0.20.0 Dec 1, 2025
46 of 51 checks passed
@bjp232004 bjp232004 deleted the kubernetes-data-source-releasev0.20 branch December 1, 2025 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

☢️ Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants