-
Notifications
You must be signed in to change notification settings - Fork 715
fix: saved views table fix #9392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjp232004
approved these changes
Nov 28, 2025
Contributor
|
Failed to generate code suggestions for PR |
Contributor
Greptile OverviewGreptile SummaryThis PR fixes display issues with saved views by preventing filter field updates in visualize mode and ensuring histogram charts redraw when the field list is toggled.
Confidence Score: 4/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant User
participant Index as Index.vue
participant SearchBar as SearchBar.vue
participant SearchResult as SearchResult.vue
User->>Index: Toggle field list (collapseFieldList)
Index->>Index: Toggle showFields state
Index->>Index: nextTick()
Index->>SearchResult: reDrawChart()
SearchResult->>SearchResult: Redraw histogram chart
User->>SearchBar: Apply saved view
SearchBar->>SearchBar: Check logsVisualizeToggle mode
alt mode is "logs"
SearchBar->>SearchBar: updatedLocalLogFilterField()
SearchBar->>SearchBar: Update filter fields
else mode is "visualize"
SearchBar->>SearchBar: Skip filter field update
Note over SearchBar: Preserve existing filter fields<br/>for visualize mode
end
SearchBar->>SearchBar: getStreams()
|
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No files reviewed, 2 comments
nikhilsaikethe
added a commit
that referenced
this pull request
Nov 28, 2025
nikhilsaikethe
added a commit
that referenced
this pull request
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.