Skip to content

Conversation

@nikhilsaikethe
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the ☢️ Bug Something isn't working label Nov 28, 2025
@github-actions
Copy link
Contributor

Failed to generate code suggestions for PR

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Nov 28, 2025

Greptile Overview

Greptile Summary

This PR fixes display issues with saved views by preventing filter field updates in visualize mode and ensuring histogram charts redraw when the field list is toggled.

  • Conditionally skips updatedLocalLogFilterField() when applying saved views in visualize mode to preserve existing filter configurations
  • Adds chart redraw logic to collapseFieldList() to fix histogram display when toggling field visibility
  • Minor style inconsistencies: missing spaces after if keywords and using == instead of === for comparisons

Confidence Score: 4/5

  • This PR is safe to merge with minor style improvements recommended
  • The logic changes are sound and address specific UI bugs with saved views and histogram rendering. The conditional logic properly checks the mode before updating filter fields. Only minor style issues exist (spacing and comparison operators) that don't affect functionality.
  • web/src/plugins/logs/SearchBar.vue needs minor style fixes for consistency

Important Files Changed

File Analysis

Filename Score Overview
web/src/plugins/logs/Index.vue 5/5 added chart redraw logic to collapseFieldList to fix display issues when toggling field list visibility
web/src/plugins/logs/SearchBar.vue 4/5 conditionally skips updatedLocalLogFilterField for visualize mode to preserve filter fields in saved views; minor style issues with spacing and comparison operators

Sequence Diagram

sequenceDiagram
    participant User
    participant Index as Index.vue
    participant SearchBar as SearchBar.vue
    participant SearchResult as SearchResult.vue
    
    User->>Index: Toggle field list (collapseFieldList)
    Index->>Index: Toggle showFields state
    Index->>Index: nextTick()
    Index->>SearchResult: reDrawChart()
    SearchResult->>SearchResult: Redraw histogram chart
    
    User->>SearchBar: Apply saved view
    SearchBar->>SearchBar: Check logsVisualizeToggle mode
    alt mode is "logs"
        SearchBar->>SearchBar: updatedLocalLogFilterField()
        SearchBar->>SearchBar: Update filter fields
    else mode is "visualize"
        SearchBar->>SearchBar: Skip filter field update
        Note over SearchBar: Preserve existing filter fields<br/>for visualize mode
    end
    SearchBar->>SearchBar: getStreams()
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No files reviewed, 2 comments

Edit Code Review Agent Settings | Greptile

@nikhilsaikethe nikhilsaikethe merged commit 3f7bc44 into branch-v0.20.0 Nov 28, 2025
19 checks passed
@nikhilsaikethe nikhilsaikethe deleted the fix/saved-views-table-fix branch November 28, 2025 14:11
nikhilsaikethe added a commit that referenced this pull request Nov 28, 2025
nikhilsaikethe added a commit that referenced this pull request Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

☢️ Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants