-
Notifications
You must be signed in to change notification settings - Fork 715
fix: cloud sync with main #9382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Failed to generate code suggestions for PR |
Contributor
Greptile OverviewGreptile SummaryThis PR addresses two UI consistency issues: dark mode visibility in alert details and icon styling in traces filters. Changes Made:
Technical Implementation:
Confidence Score: 4/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant User
participant AlertList
participant Store
participant BasicValuesFilter
participant SearchObj
Note over User,SearchObj: Dark Mode Theme Application
User->>AlertList: View alert details
AlertList->>Store: Check store.state.theme
Store-->>AlertList: Return theme ('dark' or 'light')
AlertList->>AlertList: Apply conditional Tailwind classes
Note over AlertList: tw-text-gray-400 (dark) or<br/>tw-text-gray-600 (light)
AlertList-->>User: Display themed alert details
Note over User,SearchObj: Filter Term Operations
User->>BasicValuesFilter: Click include/exclude button
BasicValuesFilter->>BasicValuesFilter: Render EqualIcon/NotEqualIcon
Note over BasicValuesFilter: Icons sized at tw-h-[0.5rem] tw-w-[0.5rem]
User->>BasicValuesFilter: Click equal icon (=)
BasicValuesFilter->>SearchObj: addSearchTerm(`field='value'`)
SearchObj->>SearchObj: Update searchObj.data.stream.addToFilter
SearchObj-->>User: Filter applied
User->>BasicValuesFilter: Click not-equal icon (≠)
BasicValuesFilter->>SearchObj: addSearchTerm(`field!='value'`)
SearchObj->>SearchObj: Update searchObj.data.stream.addToFilter
SearchObj-->>User: Exclusion filter applied
|
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 files reviewed, 1 comment
bjp232004
approved these changes
Nov 28, 2025
18b7790 to
38369d3
Compare
81ae77e to
88146c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alert details in dark mode #9379
include or exclude search term in traces #9378 9378
fixes query explain histogram title not showing issue