Skip to content

Conversation

@nikhilsaikethe
Copy link
Contributor

@nikhilsaikethe nikhilsaikethe commented Nov 28, 2025

alert details in dark mode #9379
include or exclude search term in traces #9378 9378
fixes query explain histogram title not showing issue

@github-actions github-actions bot added the ☢️ Bug Something isn't working label Nov 28, 2025
@github-actions
Copy link
Contributor

Failed to generate code suggestions for PR

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Nov 28, 2025

Greptile Overview

Greptile Summary

This PR addresses two UI consistency issues: dark mode visibility in alert details and icon styling in traces filters.

Changes Made:

  • Added theme-aware conditional styling (store.state.theme === 'dark') to alert detail drawer labels, code blocks, and status messages
  • Updated include/exclude filter buttons in traces to match the logs page styling with proper borders and icon sizing
  • Fixed incorrect tooltip on the exclude button (was "Include Term", now correctly "Exclude Term")

Technical Implementation:

  • Uses Tailwind utility classes with Vue :class bindings to toggle between light/dark color schemes
  • Applied consistent tw-h-[0.5rem] tw-w-[0.5rem] sizing to EqualIcon and NotEqualIcon components
  • Added o2-custom-button-hover class and border styling for better visual consistency

Confidence Score: 4/5

  • This PR is safe to merge with minimal risk - it only contains UI styling changes
  • Score reflects straightforward styling fixes with one minor optimization opportunity (redundant ternary on line 682). Changes follow established patterns in the codebase and address reported issues without introducing new logic
  • No files require special attention - both changes are self-contained UI improvements

Important Files Changed

File Analysis

Filename Score Overview
web/src/components/alerts/AlertList.vue 4/5 Added dark mode support to alert details drawer by applying conditional styling to labels, code blocks, and status messages
web/src/plugins/traces/fields-sidebar/BasicValuesFilter.vue 5/5 Fixed icon styling and corrected tooltip from "Include Term" to "Exclude Term" for the not-equal button, matching the logs page implementation

Sequence Diagram

sequenceDiagram
    participant User
    participant AlertList
    participant Store
    participant BasicValuesFilter
    participant SearchObj

    Note over User,SearchObj: Dark Mode Theme Application
    User->>AlertList: View alert details
    AlertList->>Store: Check store.state.theme
    Store-->>AlertList: Return theme ('dark' or 'light')
    AlertList->>AlertList: Apply conditional Tailwind classes
    Note over AlertList: tw-text-gray-400 (dark) or<br/>tw-text-gray-600 (light)
    AlertList-->>User: Display themed alert details

    Note over User,SearchObj: Filter Term Operations
    User->>BasicValuesFilter: Click include/exclude button
    BasicValuesFilter->>BasicValuesFilter: Render EqualIcon/NotEqualIcon
    Note over BasicValuesFilter: Icons sized at tw-h-[0.5rem] tw-w-[0.5rem]
    User->>BasicValuesFilter: Click equal icon (=)
    BasicValuesFilter->>SearchObj: addSearchTerm(`field='value'`)
    SearchObj->>SearchObj: Update searchObj.data.stream.addToFilter
    SearchObj-->>User: Filter applied

    User->>BasicValuesFilter: Click not-equal icon (≠)
    BasicValuesFilter->>SearchObj: addSearchTerm(`field!='value'`)
    SearchObj->>SearchObj: Update searchObj.data.stream.addToFilter
    SearchObj-->>User: Exclusion filter applied
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

@nikhilsaikethe nikhilsaikethe force-pushed the fix/cloud-sync-with-main branch 4 times, most recently from 18b7790 to 38369d3 Compare November 28, 2025 14:15
@nikhilsaikethe nikhilsaikethe force-pushed the fix/cloud-sync-with-main branch from 81ae77e to 88146c4 Compare December 1, 2025 04:47
@nikhilsaikethe nikhilsaikethe merged commit d8dc6d8 into main Dec 1, 2025
36 of 39 checks passed
@nikhilsaikethe nikhilsaikethe deleted the fix/cloud-sync-with-main branch December 1, 2025 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

☢️ Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants