Skip to content

Conversation

@Shrinath-O2
Copy link
Contributor

No description provided.

@Shrinath-O2 Shrinath-O2 added this to the v0.20.0 milestone Nov 28, 2025
@github-actions
Copy link
Contributor

Failed to generate code suggestions for PR

@github-actions github-actions bot added ☢️ Bug Something isn't working 🧹 Updates labels Nov 28, 2025
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Nov 28, 2025

Greptile Overview

Greptile Summary

Fixed failing pipeline import tests by correcting the dropdown interaction sequence. The change adds a missing stream selection step (error-0-1) and properly sequences three dropdown interactions instead of two. The fix improves test reliability by using more specific data-test attributes and adding appropriate wait times between dropdown operations.

  • Added stream dropdown selection for e2e_automate before function selections
  • Changed from error-0-1 and error-0-2 function dropdowns to error-0-2 and error-0-3
  • Improved dropdown interaction by clicking on arrow_drop_down text element directly
  • Simplified function option selection by removing .locator('div').nth(2) complexity
  • Added consistent 2-second waits after each dropdown closes to ensure UI stability

Confidence Score: 4/5

  • This PR is safe to merge with minimal risk as it only fixes test code
  • The changes only affect UI test helper methods and don't modify production code. The fix addresses a legitimate test failure by correcting the dropdown interaction sequence to match the actual UI workflow. Hard-coded timeouts may cause occasional flakiness, but this is acceptable for end-to-end tests
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
tests/ui-testing/pages/pipelinesPages/pipelinesEP.js 4/5 Fixed test flakiness by adding stream selection step and improving dropdown interaction logic

Sequence Diagram

sequenceDiagram
    participant Test as Test Suite
    participant Page as Pipeline Import Page
    participant StreamDD as Stream Dropdown
    participant FuncDD1 as Function Dropdown 1
    participant FuncDD2 as Function Dropdown 2

    Test->>Page: Fill pipeline name
    Test->>StreamDD: Click dropdown (error-0-1)
    StreamDD->>StreamDD: Wait for dropdown open (1s)
    Test->>StreamDD: Select 'e2e_automate' stream
    StreamDD->>StreamDD: Wait for dropdown close (2s)
    
    Test->>FuncDD1: Click dropdown (error-0-2)
    FuncDD1->>FuncDD1: Wait for dropdown open (1s)
    Test->>FuncDD1: Scroll to function option
    Test->>FuncDD1: Select first function
    FuncDD1->>FuncDD1: Wait for dropdown close (2s)
    
    Test->>FuncDD2: Click dropdown (error-0-3)
    FuncDD2->>FuncDD2: Wait for dropdown open (1s)
    Test->>FuncDD2: Scroll to function option
    Test->>FuncDD2: Select second function
    FuncDD2->>FuncDD2: Wait for dropdown close (2s)
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

@Shrinath-O2 Shrinath-O2 force-pushed the e2e-pipelineImportTestFix branch from 52c5bde to 128d6fc Compare November 28, 2025 06:22
@Shrinath-O2 Shrinath-O2 merged commit d65232a into main Nov 28, 2025
47 of 50 checks passed
@Shrinath-O2 Shrinath-O2 deleted the e2e-pipelineImportTestFix branch November 28, 2025 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

☢️ Bug Something isn't working 🧹 Updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants