test: Dashboard tests stable deployed #9360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktx-akshay
force-pushed
the
dashboard-tests-stable-deployed
branch
from
3f12e15 to
8b5c828
Compare
Contributor
|
Failed to generate code suggestions for PR |
ktx-akshay
force-pushed
the
dashboard-tests-stable-deployed
branch
from
8b5c828 to
5d8d8bb
Compare
Contributor
|
Failed to generate code suggestions for PR |
ktx-kirtan
approved these changes
Nov 27, 2025
Contributor
Greptile OverviewGreptile SummaryThis PR improves test stability for dashboard-related UI tests by adding explicit wait mechanisms before dashboard interactions. Key changes:
The changes follow consistent patterns from existing code (dashboard-variables.js) and address timing issues by ensuring the UI is stable before interactions. Confidence Score: 5/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant Test as Test Suite
participant Page as Page Object
participant UI as Dashboard UI
participant API as Backend API
Test->>Page: Navigate to dashboards
Test->>Page: waitForDashboardUIStable()
Page->>UI: Wait for search input (visible)
UI-->>Page: Element visible
Page->>UI: Wait for search input (attached)
UI-->>Page: Element attached
Page->>UI: Wait for New Dashboard button (visible)
UI-->>Page: Element visible
Page->>UI: Wait for New Dashboard button (attached)
UI-->>Page: Element attached
Page->>UI: Wait for Import button (visible)
UI-->>Page: Element visible
Page->>UI: Wait for Import button (attached)
UI-->>Page: Element attached
Page->>Page: Wait 500ms for animations
Page-->>Test: UI stable, ready for interaction
Test->>Page: createDashboard(name)
Page->>UI: Click New Dashboard
UI->>API: Create dashboard request
API-->>UI: Dashboard created
Test->>Page: addVariable(type, name, stream, field)
Page->>UI: Wait for dropdown options
UI-->>Page: Options loaded
alt Exact match found
Page->>UI: Click exact field match
else No exact match
alt Partial match found
Page->>UI: Click first partial match
else No partial match
Page->>UI: Use keyboard navigation (ArrowDown + Enter)
end
end
UI-->>Page: Field selected
Page-->>Test: Variable added successfully
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Shrinath-O2
force-pushed
the
dashboard-tests-stable-deployed
branch
from
5d8d8bb to
b2c3bbc
Compare
ktx-akshay
force-pushed
the
dashboard-tests-stable-deployed
branch
2 times, most recently
from
2fe2568 to
1f64089
Compare
ktx-akshay
force-pushed
the
dashboard-tests-stable-deployed
branch
from
1f64089 to
84f26f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.