-
Notifications
You must be signed in to change notification settings - Fork 715
fix: license fixes sync to main #9352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Failed to generate code suggestions for PR |
Greptile OverviewGreptile SummaryThis PR consolidates three license-related fixes: disabling license data loading for cloud environments in About page, displaying default ingestion limits when licenses expire, and simplifying meta org detection to use only identifier matching.
Confidence Score: 4/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant User
participant AboutPage as About.vue
participant LicenseComponent as License.vue
participant useIsMetaOrg
participant Store as Vuex Store
participant LicenseAPI
User->>AboutPage: Load About page
AboutPage->>AboutPage: Check config.isCloud
alt config.isCloud == 'false' (Self-hosted)
AboutPage->>LicenseAPI: loadLicenseData()
LicenseAPI-->>AboutPage: License data
AboutPage->>AboutPage: Display license info with limits
alt license.expired
AboutPage->>AboutPage: Show default limits (100 GB/day, PerDayCount)
else license valid
AboutPage->>AboutPage: Show actual license limits
end
else config.isCloud == 'true' (Cloud)
AboutPage->>AboutPage: Skip license data loading
end
User->>LicenseComponent: Access License tab in Settings
LicenseComponent->>useIsMetaOrg: Check isMetaOrg
useIsMetaOrg->>Store: Get selectedOrganization.identifier
useIsMetaOrg->>Store: Get zoConfig.meta_org
useIsMetaOrg-->>LicenseComponent: identifier === meta_org
alt isMetaOrg && isEnterprise
LicenseComponent->>LicenseComponent: Show License tab
LicenseComponent->>LicenseAPI: Load license data
LicenseAPI-->>LicenseComponent: License data
alt license.expired
LicenseComponent->>LicenseComponent: Show default limits (100 GB/day, PerDayCount)
else license valid
LicenseComponent->>LicenseComponent: Show actual license limits
end
else not meta org
LicenseComponent->>LicenseComponent: Hide License tab
end
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4 files reviewed, 2 comments
a9b0832 to
000fc27
Compare
000fc27 to
ea029f7
Compare
don't load license info for cloud in about us page
show license section for meta orgs in cloud as well
show default ingestion limit when license expired