Skip to content

Conversation

@haohuaijin
Copy link
Collaborator

@haohuaijin haohuaijin commented Nov 19, 2025

  • wait for datafusion-functions-josn
  • upgrade datafusion, arrow, opentelemetry, prost, tonic related crate

@github-actions
Copy link
Contributor

Failed to generate code suggestions for PR

@haohuaijin haohuaijin added this to the Backlog milestone Nov 24, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request upgrades the DataFusion query engine from version 50.3.0 to 51.0.0, along with related dependencies including Arrow (56→57), Parquet (56→57), and various OpenTelemetry/Tonic libraries. The upgrade adapts to breaking API changes in the DataFusion ecosystem, particularly around physical plan construction, codec interfaces, and configuration.

Key Changes:

  • Updated DataFusion APIs for physical plan codecs (SessionContext → TaskContext)
  • Adapted to fallible UnionExec::try_new() constructor
  • Updated protobuf/tonic stack from 0.13 to 0.14
  • Fixed return value handling for span.set_parent()

Reviewed changes

Copilot reviewed 34 out of 37 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Cargo.toml, Cargo.lock Upgraded DataFusion, Arrow, Parquet, Tonic, and OpenTelemetry dependencies
src/service/search/datafusion/exec.rs Updated SQL dialect configuration to use enum instead of string
src/service/search/datafusion/table_provider/*.rs Updated physical plan APIs and ParquetFileReaderFactory signature
src/service/search/datafusion/distributed_plan/codec/*.rs Migrated from FunctionRegistry to TaskContext in codec interfaces
src/service/search/grpc/flight.rs Updated physical plan deserialization to use TaskContext
src/flight/src/*.rs Updated IPC encoding to use CompressionContext
src/proto/build.rs Switched from tonic::codec to tonic_prost for protobuf encoding
src/handler/grpc/**/*.rs Fixed span.set_parent() return value handling
src/infra/src/storage/mod.rs Updated parquet metadata API to use FooterTail

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@haohuaijin haohuaijin merged commit 9190a9d into main Nov 25, 2025
35 of 37 checks passed
@haohuaijin haohuaijin deleted the upgrade-datafusion-to-51 branch November 25, 2025 15:16
@haohuaijin haohuaijin modified the milestones: Backlog, v0.30.0 Dec 1, 2025
@haohuaijin haohuaijin added the Needs-Testing Needs-Testing label Dec 1, 2025
@Shrinath-O2 Shrinath-O2 added Testing-Completed Testing-Completed and removed Needs-Testing Needs-Testing labels Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants