-
Notifications
You must be signed in to change notification settings - Fork 715
fix: skip local storage cache for print dashboard #8997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Failed to generate code suggestions for PR |
|
| Status | Total | Passed | Failed | Skipped | Flaky | Pass Rate | Duration |
|---|---|---|---|---|---|---|---|
| All tests passed | 371 | 348 | 0 | 22 | 1 | 94% | 5m 1s |
8218d23 to
b3054e8
Compare
|
Failed to generate code suggestions for PR |
|
| Status | Total | Passed | Failed | Skipped | Flaky | Pass Rate | Duration |
|---|---|---|---|---|---|---|---|
| All tests passed | 371 | 345 | 0 | 24 | 2 | 93% | 5m 30s |
|
| Status | Total | Passed | Failed | Skipped | Flaky | Pass Rate | Duration |
|---|---|---|---|---|---|---|---|
| All tests passed | 371 | 344 | 0 | 24 | 3 | 93% | 5m 35s |
|
This PR has been inactive for 14 days. Please update or we will close it soon. |
|
Failed to generate code suggestions for PR |
Greptile OverviewGreptile SummaryModified cache restoration logic in
Confidence Score: 5/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant ViewDashboard
participant RenderDashboardCharts
participant PanelSchemaRenderer
participant usePanelDataLoader
participant Cache
participant SearchAPI
ViewDashboard->>ViewDashboard: User triggers print mode
ViewDashboard->>RenderDashboardCharts: forceLoad=store.state.printMode (true)
RenderDashboardCharts->>PanelSchemaRenderer: forceLoad=true
PanelSchemaRenderer->>usePanelDataLoader: Initialize with forceLoad=true
Note over usePanelDataLoader: loadData() called with runCount=0
alt forceLoad=true AND runCount=0
usePanelDataLoader->>usePanelDataLoader: Skip cache check (line 800)
Note over usePanelDataLoader,Cache: Cache restoration skipped
else forceLoad=false AND runCount=0
usePanelDataLoader->>Cache: restoreFromCache()
Cache-->>usePanelDataLoader: Return cached data if available
else runCount>0
usePanelDataLoader->>usePanelDataLoader: Skip cache (subsequent load)
end
usePanelDataLoader->>SearchAPI: Fetch fresh data
SearchAPI-->>usePanelDataLoader: Return data
usePanelDataLoader->>PanelSchemaRenderer: Display fresh data
PanelSchemaRenderer->>RenderDashboardCharts: Render panel
RenderDashboardCharts->>ViewDashboard: Dashboard ready for print
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 files reviewed, no comments
No description provided.