feat: support shared memtable for many orgs #8943
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
Testdino Test Results
|
bjp232004
approved these changes
Nov 4, 2025
YashodhanJoshi1
approved these changes
Nov 4, 2025
haohuaijin
approved these changes
Nov 4, 2025
uddhavdave
approved these changes
Nov 4, 2025
yaga-simha
approved these changes
Nov 4, 2025
Contributor
yaga-simha
left a comment
yaga-simha
left a comment
There was a problem hiding this comment.
LGTM. I guess the 1:1 performance comparison for low intensity usecase will be identical but higher the number of orgs the better this solution scales.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current version will create memtable for each org and streamType. we will create 3000 memtables if you have 1000 orgs and both write logs, metrics and traces. This is unacceptable in some customers.
This PR implement a new feature that we let multiple orgs write to a same memtable by hashing.
You can enable this feature by set env:
This config will maximum create 30 memtables.
Metrics compatible issue
This PR also fixed metrics compatible reduced issue, it is because of we removed
__name__label in the response.