feat: log patterns #8927
Merged
feat: log patterns #8927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
Contributor
|
Failed to generate code suggestions for PR |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
| Status | Total | Passed | Failed | Skipped | Flaky | Pass Rate | Duration |
|---|---|---|---|---|---|---|---|
| All tests passed | 376 | 353 | 0 | 21 | 2 | 94% | 4m 58s |
|
| Status | Total | Passed | Failed | Skipped | Flaky | Pass Rate | Duration |
|---|---|---|---|---|---|---|---|
| All tests passed | 376 | 352 | 0 | 21 | 3 | 94% | 4m 58s |
|
| Status | Total | Passed | Failed | Skipped | Flaky | Pass Rate | Duration |
|---|---|---|---|---|---|---|---|
| All tests passed | 376 | 352 | 0 | 21 | 3 | 94% | 5m 1s |
|
| Status | Total | Passed | Failed | Skipped | Flaky | Pass Rate | Duration |
|---|---|---|---|---|---|---|---|
| 1 test failed | 376 | 349 | 1 | 22 | 4 | 93% | 5m 32s |
Test Failure Analysis
- unflattened.spec.js: Test failures due to timeout waiting for element visibility
- Unflattened testcases stream to toggle store original data toggle and display o2 id: Timeout waiting for toggle button to become visible.
Root Cause Analysis
- The recent code change in schema.vue may have affected the visibility of the toggle button.
Recommended Actions
- Increase the timeout duration in the test to allow more time for the toggle button to appear. 2. Verify the condition for rendering the toggle button in schema.vue to ensure it is correctly displayed. 3. Add a check to confirm the toggle button's presence before attempting to interact with it.
omkarK06
force-pushed
the
feat-log-patterns
branch
from
f7975c1 to
dd58a30
Compare
|
| Status | Total | Passed | Failed | Skipped | Flaky | Pass Rate | Duration |
|---|---|---|---|---|---|---|---|
| 5 tests failed | 158 | 134 | 5 | 13 | 6 | 85% | 7m 21s |
Test Failure Analysis
- pipeline-dynamic.spec.js: All tests failing due to timeout errors on locator clicks
- Pipeline Dynamic Stream Names Verify pipeline with dynamic destination name using kubernetes_container_name directly: Timeout waiting for menu locator to be clickable.
- Pipeline Dynamic Stream Names Verify pipeline with dynamic destination name using kubernetes_container_name with underscores: Timeout waiting for menu locator to be clickable.
- Pipeline Dynamic Stream Names Verify pipeline with dynamic destination name using kubernetes_container_name: Timeout waiting for menu locator to be clickable.
- pipeline-core.spec.js: Tests failing due to timeout errors on locator clicks
- Core Pipeline Tests should add source, condition & destination node and then delete the pipeline: Timeout waiting for menu locator to be clickable.
- Core Pipeline Tests should add source & destination node and then delete the pipeline: Timeout waiting for menu locator to be clickable.
Root Cause Analysis
- The recent code changes in AlertList.vue and Index.vue do not directly relate to the timeout issues in the failing tests.
Recommended Actions
- Investigate the visibility and loading time of the locator '[data-test="log-table-column-1-_timestamp"] [data-test="table-row-expand-menu"]' in both pipeline-dynamic.spec.js and pipeline-core.spec.js.
- Increase the timeout duration for the click actions in the affected tests to accommodate potential delays.
- Ensure that the elements are present and visible before attempting clicks to avoid timeout errors.
hengfeiyang
approved these changes
Nov 3, 2025
|
| Status | Total | Passed | Failed | Skipped | Flaky | Pass Rate | Duration |
|---|---|---|---|---|---|---|---|
| 5 tests failed | 158 | 134 | 5 | 13 | 6 | 85% | 7m 20s |
Test Failure Analysis
- pipeline-dynamic.spec.js: All tests fail due to timeout waiting for locators
- Pipeline Dynamic Stream Names verify pipeline with dynamic destination name using kubernetes_container_name directly: Timeout waiting for the timestamp menu locator.
- Pipeline Dynamic Stream Names verify pipeline with dynamic destination name using kubernetes_container_name with underscores: Timeout waiting for the timestamp menu locator.
- Pipeline Dynamic Stream Names verify pipeline with dynamic destination name using kubernetes_container_name: Timeout waiting for the timestamp menu locator.
- pipeline-core.spec.js: Tests fail due to timeout waiting for locators
- Core Pipeline Tests should add source, condition & destination node and then delete the pipeline: Timeout waiting for the timestamp menu locator.
- Core Pipeline Tests should add source & destination node and then delete the pipeline: Timeout waiting for the timestamp menu locator.
Root Cause Analysis
- The failures are likely due to recent changes in the locator handling in the pipelines, specifically in pipeline-core.spec.js and pipeline-dynamic.spec.js.
Recommended Actions
- Investigate the locator '[data-test="log-table-column-1-_timestamp"] [data-test="table-row-expand-menu"]' for visibility issues in both pipeline-dynamic.spec.js and pipeline-core.spec.js. 2. Increase the timeout duration for locators in the affected tests to allow more time for elements to become available. 3. Review recent changes in the UI that may affect the rendering of the timestamp menu.
|
| Status | Total | Passed | Failed | Skipped | Flaky | Pass Rate | Duration |
|---|---|---|---|---|---|---|---|
| 1 test failed | 376 | 351 | 1 | 22 | 2 | 93% | 5m 2s |
Test Failure Analysis
- unflattened.spec.js: Test failures due to timeout waiting for element visibility
- Unflattened testcases stream to toggle store original data toggle and display o2 id: Timeout waiting for toggle button to be visible.
Root Cause Analysis
- The code changes in [VUE] SearchResult.vue may have affected the rendering of the toggle button, causing visibility issues.
Recommended Actions
- Increase the timeout duration in the test to allow more time for the toggle to become visible.
- Verify the rendering logic in [VUE] SearchResult.vue to ensure the toggle button is displayed correctly.
- Add a check to confirm the toggle button's presence before waiting for its visibility.
oasisk
force-pushed
the
feat-log-patterns
branch
from
57bb7df to
06d2819
Compare
|
| Status | Total | Passed | Failed | Skipped | Flaky | Pass Rate | Duration |
|---|---|---|---|---|---|---|---|
| 1 test failed | 376 | 350 | 1 | 22 | 3 | 93% | 5m 1s |
Test Failure Analysis
- unflattened.spec.js: Timeout issues while waiting for UI elements to become visible
- Unflattened testcases stream to toggle store original data toggle and display o2 id: Timeout waiting for toggle button to be visible.
Root Cause Analysis
- The changes in [VUE] SearchResult.vue may have affected the visibility of UI elements, leading to timeout errors in the test.
Recommended Actions
- Increase the timeout duration in the test to accommodate slower UI rendering.
- Verify the visibility condition of the toggle button in the updated component to ensure it is rendered correctly.
- Add a wait or check for the parent element's visibility before checking the toggle button.
oasisk
force-pushed
the
feat-log-patterns
branch
from
33a723b to
d26f118
Compare
|
| Status | Total | Passed | Failed | Skipped | Flaky | Pass Rate | Duration |
|---|---|---|---|---|---|---|---|
| All tests passed | 376 | 352 | 0 | 21 | 3 | 94% | 4m 31s |
|
| Status | Total | Passed | Failed | Skipped | Flaky | Pass Rate | Duration |
|---|---|---|---|---|---|---|---|
| All tests passed | 376 | 350 | 0 | 21 | 5 | 93% | 4m 30s |
|
| Status | Total | Passed | Failed | Skipped | Flaky | Pass Rate | Duration |
|---|---|---|---|---|---|---|---|
| All tests passed | 376 | 352 | 0 | 21 | 3 | 94% | 4m 32s |
…alled for all table rows
oasisk
force-pushed
the
feat-log-patterns
branch
from
c8cbee7 to
e22153f
Compare
Contributor
|
@oasisk This feature is missing in the UI even though the blog mentions it for 0.16.x I'm running 0.16.1 OSS self hosted |
Contributor
|
Hi gaby, This is an ent feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR introduces below features:
Enterprise features: