Greptile Overview

Greptile Summary

Refactored query recommendations to use ingestion_service::ingest instead of direct Ingester gRPC calls, ensuring ingestion requests are properly routed to ingester nodes regardless of where they originate. Removed the retry mechanism from the trigger handler - the job now always schedules the next run regardless of success or failure, preventing issues where non-ingester nodes would retry indefinitely.

Key Changes:

• Replaced Ingester::ingest() with ingestion_service::ingest() in query_optimization_recommendation.rs:89-91 to properly route to ingester nodes
• Removed retry logic from handlers.rs that decremented retries and set status to Processing
• Simplified error handling to always queue next run, preventing the trigger from getting stuck
• Added consistent [QUERY_RECOMMENDATIONS] prefix to all log messages for better traceability

Confidence Score: 5/5

• This PR is safe to merge with minimal risk
• The changes are well-structured and address a real architectural issue. The switch from direct Ingester calls to ingestion_service::ingest ensures proper routing to ingester nodes. Removing the retry mechanism simplifies the logic and prevents the system from getting stuck. The changes maintain existing error logging while ensuring the scheduler continues to function. All modifications are focused and don't introduce new complexity or potential bugs.
• No files require special attention

Important Files Changed

File Analysis

Sequence Diagram

sequenceDiagram
    participant Scheduler
    participant Handler as Query Recommendations Handler
    participant Service as QueryRecommendationService
    participant IngestService as ingestion_service
    participant Ingester as Ingester Node
    participant DB as Trigger Database

    Scheduler->>Handler: Trigger query_recommendations job
    Note over Handler: No retry decrement<br/>(removed in this PR)
    Handler->>Service: run()
    Service->>Service: Analyze queries & generate recommendations
    Service->>IngestService: ingest(recommendations)
    Note over IngestService: NEW: Routes to ingester node<br/>instead of local call
    IngestService->>Ingester: Forward request to ingester node
    Ingester-->>IngestService: IngestionResponse
    IngestService-->>Service: Result
    Service-->>Handler: Result (success or error)
    Handler->>DB: update_trigger(status=Waiting, retries=3, next_run_at)
    Note over Handler: Always schedules next run<br/>regardless of result
    Handler->>Handler: Log error if failed (but don't propagate)
    Handler-->>Scheduler: Ok(())

_{3 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}