Skip to content

Conversation

@ktx-akshay
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added ☢️ Bug Something isn't working 🧹 Updates labels Oct 29, 2025
@github-actions
Copy link
Contributor

Failed to generate code suggestions for PR

@testdino-playwright-reporter
Copy link

⚠️ Test Run Unstable


Author: ktx-akshay | Branch: API-Version-Change | Commit: 196db4c

Testdino Test Results

Status Total Passed Failed Skipped Flaky Pass Rate Duration
All tests passed 366 344 0 19 3 94% 4m 39s

View Detailed Results

@ktx-kirtan ktx-kirtan marked this pull request as ready for review October 29, 2025 05:39
@github-actions
Copy link
Contributor

Failed to generate code suggestions for PR

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Overview

Greptile Summary

Updates test suite to align with dashboard schema version v6 migration. All API response assertions that previously accessed v5.dashboardId, v5.title, and other v5 fields now correctly reference v6 fields.

  • Updated 40+ assertions in test_dashboards.py from v5 to v6 schema references
  • Updated 4 dashboard ID extractions in test_folders.py folder-dashboard integration tests
  • Also relaxed error code expectations for nonexistent dashboard operations (now accepts 500 status code) to match current API behavior

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • Straightforward mechanical change updating schema version references from v5 to v6 across test assertions. The changes are consistent, comprehensive, and align with the dashboard migration commit (8a68394) that introduced v6 schema support. No logic changes, only updating field access paths to match new API response structure.
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
tests/api-testing/tests/test_dashboards.py 5/5 Updated all dashboard API response references from v5 to v6 schema version consistently across 40+ test assertions
tests/api-testing/tests/test_folders.py 5/5 Updated dashboard ID extraction from v5 to v6 schema in folder-related dashboard tests

Sequence Diagram

sequenceDiagram
    participant Test as Test Suite
    participant API as Dashboard API
    participant DB as Database
    
    Note over Test,DB: Dashboard Creation Flow
    Test->>API: POST /api/org/dashboards (dashboard data)
    API->>DB: Store dashboard with schema v6
    DB-->>API: Dashboard created
    API-->>Test: Response with v6.dashboardId
    
    Note over Test,DB: Dashboard Retrieval Flow
    Test->>API: GET /api/org/dashboards/{id}
    API->>DB: Fetch dashboard
    DB-->>API: Dashboard data (v6 schema)
    API-->>Test: Response with v6 fields (title, description, tabs, variables)
    
    Note over Test,DB: Schema Version Migration
    Note right of API: v5 → v6 migration applied<br/>All responses now use v6 schema<br/>Tests updated to match
Loading

2 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@testdino-playwright-reporter
Copy link

⚠️ Test Run Unstable


Author: ktx-akshay | Branch: API-Version-Change | Commit: 25c7afd

Testdino Test Results

Status Total Passed Failed Skipped Flaky Pass Rate Duration
All tests passed 366 343 0 19 4 94% 4m 38s

View Detailed Results

@testdino-playwright-reporter
Copy link

⚠️ Test Run Unstable


Author: ktx-akshay | Branch: API-Version-Change | Commit: 25c7afd

Testdino Test Results

Status Total Passed Failed Skipped Flaky Pass Rate Duration
All tests passed 366 346 0 19 1 95% 4m 38s

View Detailed Results

@ktx-akshay ktx-akshay merged commit 766bd14 into main Oct 29, 2025
33 checks passed
@ktx-akshay ktx-akshay deleted the API-Version-Change branch October 29, 2025 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

☢️ Bug Something isn't working 🧹 Updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants