Greptile Overview

Greptile Summary

This PR adds test coverage for the "connect null values" toggle functionality in dashboard visualization config. The test verifies that the toggle defaults to true when visualizing histogram queries with HAVING clauses.

Key Changes:

• Added page object methods (getConnectNullValuesState() and verifyConnectNullValuesToggle()) to dashboard-panel-configs.js following existing patterns for toggle state verification
• Added new test case to verify default state of connect null values toggle with histogram queries containing HAVING clauses
• New SQL query constant histogramQueryWithHaving added for testing this specific scenario

Quality Notes:

• Implementation follows existing codebase patterns (mirroring verifyQuickModeToggle approach)
• Test includes dual assertions (custom verification method + Playwright expect) for robustness
• Uses waitForTimeout(1000) which is acceptable for waiting on UI panel visibility in this context

Confidence Score: 5/5

• This PR is safe to merge with minimal risk - adds test coverage without modifying production code
• The PR only adds test code following established patterns in the codebase. The page object methods mirror existing toggle verification methods (like verifyQuickModeToggle), ensuring consistency. The test case is straightforward and well-structured with clear steps. No production code changes means zero risk of runtime issues.
• No files require special attention

Important Files Changed

File Analysis

Sequence Diagram

sequenceDiagram
    participant Test as Test Suite
    participant PM as PageManager
    participant Visualise as LogsVisualise
    participant PanelConfig as DashboardPanelConfigs
    participant UI as Dashboard UI
    
    Test->>PM: Create PageManager instance
    Test->>Visualise: openLogs()
    Test->>Visualise: fillLogsQueryEditor(histogramQueryWithHaving)
    Test->>Visualise: setRelative("6", "w")
    Test->>Visualise: logsApplyQueryButton()
    Test->>Visualise: openVisualiseTab()
    Visualise->>UI: Switch to visualization tab
    Test->>Visualise: verifyChartRenders(page)
    Visualise-->>Test: Chart renders successfully
    
    Test->>PanelConfig: Create DashboardPanelConfigs instance
    Test->>PanelConfig: openConfigPanel()
    PanelConfig->>UI: Click config sidebar
    UI-->>PanelConfig: Config panel visible
    
    Test->>Test: waitForTimeout(1000)
    Test->>PanelConfig: verifyConnectNullValuesToggle(true)
    PanelConfig->>PanelConfig: getConnectNullValuesState()
    PanelConfig->>UI: waitFor connectNullValuesToggle visible
    PanelConfig->>UI: getAttribute("aria-checked")
    alt aria-checked is null
        PanelConfig->>UI: getAttribute("aria-pressed")
    end
    UI-->>PanelConfig: Return "true"
    PanelConfig->>PanelConfig: Validate expected vs actual state
    PanelConfig-->>Test: Return toggle state (true)
    
    Test->>Test: expect(connectNullState).toBe(true)
    Test->>UI: Locate connect null toggle
    Test->>UI: expect toHaveAttribute("aria-checked", "true")

_{2 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}