Greptile Overview

Greptile Summary

Added timeout configuration to internal ingestion gRPC calls to prevent indefinite hangs. The default timeout is set to 600 seconds, matching the query timeout setting.

Key Changes:

• Updated ZO_QUERY_INGESTER_TIMEOUT default from 0 (no timeout) to 600 seconds in config.rs:1295
• Applied timeout to gRPC requests in ingestion_service.rs:40-43 using request.set_timeout()
• Follows existing pattern used in other gRPC clients like make_grpc_search_client in infra/src/client/grpc.rs:115

Impact:

• Affects internal ingestion calls from alerts, self-reporting, and cloud events services
• Prevents indefinite blocking on slow or unresponsive ingester nodes
• Improves system resilience and observability

Confidence Score: 5/5

• This PR is safe to merge with minimal risk
• The changes follow established patterns in the codebase, add critical timeout protection to prevent indefinite hangs, and use a reasonable default value that matches the query timeout. The implementation is simple, well-scoped, and addresses a real operational concern.
• No files require special attention

Important Files Changed

File Analysis

Sequence Diagram

sequenceDiagram
    participant Caller as Calling Service<br/>(Alerts/SelfReporting)
    participant IS as ingestion_service::ingest
    participant Config as Configuration
    participant Client as IngestClient<br/>(gRPC)
    participant Ingester as Remote Ingester Node

    Caller->>IS: ingest(IngestionRequest)
    IS->>Config: get_config()
    Config-->>IS: query_ingester_timeout: 600s
    IS->>IS: Create tonic::Request
    IS->>IS: Set timeout to 600s
    IS->>Client: Configure compression & message size
    Client->>Ingester: ingest(request) with 600s timeout
    alt Success
        Ingester-->>Client: IngestionResponse
        Client-->>IS: Ok(response)
        IS-->>Caller: Ok(IngestionResponse)
    else Timeout or Error
        Ingester-->>Client: Error/Timeout
        Client-->>IS: Err(e)
        IS->>IS: Log error
        IS-->>Caller: Err(IngestionError)
    end

_{2 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}