-
Notifications
You must be signed in to change notification settings - Fork 715
chore(deps-dev): bump happy-dom from 16.8.1 to 20.0.0 in /web #8788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps-dev): bump happy-dom from 16.8.1 to 20.0.0 in /web #8788
Conversation
Bumps [happy-dom](https://github.com/capricorn86/happy-dom) from 16.8.1 to 20.0.0. - [Release notes](https://github.com/capricorn86/happy-dom/releases) - [Commits](capricorn86/happy-dom@v16.8.1...v20.0.0) --- updated-dependencies: - dependency-name: happy-dom dependency-version: 20.0.0 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greptile Overview
Summary
This PR updates the happy-dom dev dependency from 16.8.1 to 20.0.0. The update includes a major version bump with a significant breaking change: JavaScript evaluation is now disabled by default due to a security vulnerability (GHSA-37j7-fg3j-429f).
Key findings:
- The project currently uses
jsdomas its test environment (configured invitest.config.ts:21), nothappy-dom happy-domappears to be an unused dependency that may have been included speculatively or for potential future use- The breaking change requiring
enableJavaScriptEvaluationto be explicitly enabled does not affect this project sincehappy-domis not actively used - The codebase does contain code that uses
eval()andnew Function()(in custom chart rendering), but these are protected with security checks and run in the application context, not in the test environment
Additional changes in v20.0.0:
- Removed CommonJS support (ESM only)
- Updated Jest to v30 in the Jest environment package
- Added new
@happy-dom/server-rendererpackage - Added support for CSS pseudo selector
:scope - Various bug fixes and improvements
Confidence Score: 5/5
- This PR is safe to merge with minimal risk since happy-dom is not actively used in the test suite
- The dependency update poses no risk because the project uses jsdom instead of happy-dom for testing. The breaking change (JavaScript evaluation disabled by default) does not affect this codebase. This is a standard automated dependency update with no functional impact.
- No files require special attention
Important Files Changed
File Analysis
| Filename | Score | Overview |
|---|---|---|
| web/package.json | 5/5 | Dependency version bump from 16.8.1 to 20.0.0 - appears to be unused in tests |
| web/package-lock.json | 5/5 | Automatic lockfile update with transitive dependency changes |
Sequence Diagram
sequenceDiagram
participant Dependabot
participant PackageJSON
participant NPM
participant CI
Dependabot->>PackageJSON: Detect happy-dom 16.8.1 outdated
Dependabot->>PackageJSON: Update to 20.0.0
Dependabot->>NPM: Run npm install
NPM->>PackageJSON: Update package-lock.json
NPM-->>Dependabot: Dependencies resolved
Dependabot->>CI: Create PR #8788
CI->>CI: Run tests with jsdom (not happy-dom)
CI-->>Dependabot: Tests pass/fail
1 file reviewed, no comments
|
| Status | Total | Passed | Failed | Skipped | Flaky | Pass Rate | Duration |
|---|---|---|---|---|---|---|---|
| All tests passed | 364 | 333 | 0 | 19 | 12 | 91% | 5m 1s |
|
A newer version of happy-dom exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
Testdino Test Results
|
Bumps happy-dom from 16.8.1 to 20.0.0.
Release notes
Sourced from happy-dom's releases.
... (truncated)
Commits
819d15bBREAKING CHANGE: #0 Changes JavaScript evaluation to be disabled by default...c80a08ffix: #1620 Fixes issue related to CSS pseudo selector :scope (#1911)220df23fix: #1908 Fixes issue with sending in URLs as string in server-renderer co...9849f8bchore: #1906 Fixes failing unit test caused by package version (#1907)48d174echore: #1904 Updates conventional commit package (#1905)275efe5BREAKING CHANGE: #1620 Release v18.0.0cf74f5ffix: #1841 Addresses an issue where an error occurred if the Element ID was...bfd0fffchore: #1154 Fixes failing unit test (#1843)99ebbfcBREAKING CHANGE: #1154 Makes the types for Happy DOM strict (#1842)a94d780fix: #1154 Removes global typescript definition that was used for custom el...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.