fix: dashboard ensure case-insensitive comparison for stream field va… #8428
Conversation
…lidation for camelCase (#8424) ### **PR Type** Bug fix ___ ### **Description** - Make stream field validation case-insensitive - Prevent false errors for camelCase vs snake_case ___ ### Diagram Walkthrough ```mermaid flowchart LR A["Query field names"] -- "toLowerCase()" --> B["Normalized names"] C["Available stream fields"] -- "toLowerCase()" --> D["Normalized fields"] B -- "compare" --> D E["Errors array"] -- "only push if unmatched" --> F["Accurate validation"] ``` <details> <summary><h3> File Walkthrough</h3></summary> <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Bug fix</strong></td><td><table> <tr> <td> <details> <summary><strong>convertDataIntoUnitValue.ts</strong><dd><code>Case-insensitive comparison for stream field validation</code> </dd></summary> <hr> web/src/utils/dashboard/convertDataIntoUnitValue.ts <ul><li>Compare field names using toLowerCase().<br> <li> Avoid mismatch when cases differ (e.g., camelCase).<br> <li> Update filter predicate for custom X field errors.</ul> </details> </td> <td><a href="https://github.com/openobserve/openobserve/pull/8424/files#diff-14c6fe442ef231566ec411f9e0262cdd24ec912fc67b9154eec743282ab7211a">+4/-1</a> </td> </tr> </table></td></tr></tr></tbody></table> </details> ___ --------- Co-authored-by: ktx-akshay <[email protected]>
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Greptile Summary
This PR fixes a dashboard validation bug by making stream field comparison case-insensitive. The issue occurred in the validateStreamFields function within convertDataIntoUnitValue.ts, where field name validation was performing exact string matching between query field names (it.column) and available stream field names (i.name). This caused false validation errors when field names had different casing conventions - for example, when frontend code used camelCase field names but the backend provided snake_case equivalents.
The fix normalizes both field names to lowercase using .toLowerCase() before comparison in two locations: the X-axis field validation (line 1212) and Y-axis field validation (line 1230). This change ensures that fields like userName and user_name are correctly recognized as the same field during validation.
This change integrates well with OpenObserve's dashboard system, which needs to handle field names that may be transformed during data processing pipelines. The case-insensitive approach is common in data systems where field naming conventions can vary between different layers of the application stack, making this a pragmatic solution for improving user experience by eliminating confusing validation errors.
Confidence score: 5/5
- This PR is safe to merge with minimal risk as it only affects field validation logic without changing core functionality
- Score reflects a simple, well-targeted bug fix that addresses a clear validation issue with no side effects
- No files require special attention - the change is isolated and straightforward
1 file reviewed, no comments
…lidation for camelCase (#8424) (#8428) …lidation for camelCase (#8424) ### **PR Type** Bug fix ___ ### **Description** - Make stream field validation case-insensitive - Prevent false errors for camelCase vs snake_case ___ ### Diagram Walkthrough ```mermaid flowchart LR A["Query field names"] -- "toLowerCase()" --> B["Normalized names"] C["Available stream fields"] -- "toLowerCase()" --> D["Normalized fields"] B -- "compare" --> D E["Errors array"] -- "only push if unmatched" --> F["Accurate validation"] ``` <details> <summary><h3> File Walkthrough</h3></summary> <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Bug fix</strong></td><td><table> <tr> <td> <details> <summary><strong>convertDataIntoUnitValue.ts</strong><dd><code>Case-insensitive comparison for stream field validation</code> </dd></summary> <hr> web/src/utils/dashboard/convertDataIntoUnitValue.ts <ul><li>Compare field names using toLowerCase().<br> <li> Avoid mismatch when cases differ (e.g., camelCase).<br> <li> Update filter predicate for custom X field errors.</ul> </details> </td> <td><a href="https://github.com/openobserve/openobserve/pull/8424/files#diff-14c6fe442ef231566ec411f9e0262cdd24ec912fc67b9154eec743282ab7211a">+4/-1</a> </td> </tr> </table></td></tr></tr></tbody></table> </details> ___ --------- Co-authored-by: ktx-akshay <[email protected]>
…lidation for camelCase (#8424)
PR Type
Bug fix
Description
Make stream field validation case-insensitive
Prevent false errors for camelCase vs snake_case
Diagram Walkthrough
File Walkthrough
convertDataIntoUnitValue.ts
Case-insensitive comparison for stream field validationweb/src/utils/dashboard/convertDataIntoUnitValue.ts