Skip to content

Conversation

@ktx-abhay
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added the ☢️ Bug Something isn't working label Sep 12, 2025
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Summary

This PR adds a new __axisValue property to the drilldown variables in the PanelSchemaRenderer.vue component to fix axis value handling when drilling down from dashboard charts to logs. The change addresses issue #8404 where axis values (such as timestamps or category values) were not being properly preserved during the drilldown navigation process.

The implementation adds a single line that creates the __axisValue property with a fallback strategy: it first attempts to use the first element of the drilldown parameters value array (drilldownParams[0]?.value?.[0]) and falls back to the name property if the value is unavailable. This ensures that when users click on chart elements to drill down to logs, the system maintains the axis context for proper filtering and data relevance.

The fix integrates with the existing drilldown infrastructure in the dashboard system, where the PanelSchemaRenderer component handles various chart types and user interactions. The drilldown functionality allows users to navigate from high-level chart visualizations to detailed logs views, and this change ensures that the axis information (like time ranges or categorical filters) corresponding to the clicked chart element is preserved during the transition. This maintains the contextual relationship between the chart data point and the resulting logs view, providing a seamless user experience.

Confidence score: 4/5

  • This PR is safe to merge with minimal risk as it only adds a single property with proper fallback handling
  • Score reflects the focused nature of the change and robust fallback implementation that handles different data formats
  • Pay close attention to the PanelSchemaRenderer.vue file to ensure the drilldown variables structure aligns with expectations

1 file reviewed, no comments

Edit Code Review Bot Settings | Greptile

@ktx-abhay ktx-abhay merged commit f1d6c08 into branch-v0.14.6-rc9 Sep 12, 2025
47 of 49 checks passed
@ktx-abhay ktx-abhay deleted the fix/drilldown-axisvalue-issue-rc9 branch September 12, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

☢️ Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants