-
Notifications
You must be signed in to change notification settings - Fork 715
test: e2e-add-to-table-tests #8257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Reviewer Guide 🔍(Review updated until commit 7dc3f92)Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Latest suggestions up to 7dc3f92
Previous suggestionsSuggestions up to commit 7dc3f92
|
|
Persistent review updated to latest commit 7dc3f92 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greptile Summary
This PR adds end-to-end testing capabilities for logs table field management functionality. The changes extend the existing LogsPage Page Object Model (POM) with new methods to support adding and removing fields from the logs table view, and creates a comprehensive test suite to verify this functionality.
Key Changes:
-
LogsPage POM Extension - Added five new methods to
tests/ui-testing/pages/logsPages/logsPage.js:hoverOnFieldExpandButton()- Reveals field action buttons by hoveringclickAddFieldToTableButton()- Adds a field to the table viewclickRemoveFieldFromTableButton()- Removes a field from the table viewexpectFieldInTableHeader()- Verifies field presence in table headersexpectFieldNotInTableHeader()- Verifies field removal from table headers
-
New Test Suite - Created
tests/ui-testing/playwright-tests/Logs/logstable.spec.jswith comprehensive E2E tests that:- Test the complete workflow of adding and removing fields
- Verify field persistence after page refresh
- Include data ingestion helpers to seed test data
- Handle proper test setup/teardown with navigation and mode toggling
-
CI Integration - Updated
.github/workflows/playwright.ymlto include the new test file in the Logs-Core test category, ensuring it runs as part of the continuous integration pipeline.
The implementation follows established testing patterns in the codebase, using data-test attributes for stable element selection and including appropriate wait timeouts to handle asynchronous UI updates. The new methods integrate seamlessly with the existing LogsPage class architecture and maintain consistent naming conventions.
Confidence score: 5/5
- This PR is extremely safe to merge with minimal risk of production issues
- Score reflects simple test-only changes with no impact on production code
- No files require special attention as these are isolated testing improvements
2 files reviewed, 1 comment
PR Type
Tests, Enhancement
Description
Add logs table field management tests
Extend LogsPage POM with field actions
Integrate new test into Playwright workflow
Include ingestion helper for test setup
Diagram Walkthrough
File Walkthrough
logsPage.js
POM: field add/remove helpers for logs tabletests/ui-testing/pages/logsPages/logsPage.js
logstable.spec.js
Add logs table field management E2E teststests/ui-testing/playwright-tests/Logs/logstable.spec.js
playwright.yml
CI: include logs table tests in workflow.github/workflows/playwright.yml