fix: capital stream can't search #4978

haohuaijin · 2024-11-04T09:11:03Z

Summary by CodeRabbit

New Features
- Enhanced handling of SQL stream names to prevent syntax errors with special characters.
Bug Fixes
- Improved error handling for scenarios with no available querier nodes and empty search conditions.
Refactor
- Refined logic for constructing SQL queries and clarified conditions for using inverted indexes.

coderabbitai · 2024-11-04T09:11:13Z

Walkthrough

The pull request introduces modifications to the src/service/search/cluster/flight.rs file, focusing on the register_table function and SQL stream name handling. Key changes include formatting the stream_name variable with double quotes to prevent SQL syntax errors, refining SQL query construction in the get_inverted_index_file_lists and get_inverted_index_file_list functions, and enhancing error handling for various conditions. The overall control flow remains unchanged, but the logic within existing functions is improved for clarity and robustness.

Changes

File	Change Summary
`src/service/search/cluster/flight.rs`	- Modified `register_table` to format `stream_name` with double quotes. - Refined logic in `get_inverted_index_file_lists` and `get_inverted_index_file_list` for SQL query construction. - Enhanced error handling and logging for various conditions.

Possibly related PRs

feat: new search engine #4182: The changes in src/service/search/cluster/mod.rs regarding the handling of the schema_latest variable may relate to the modifications in SQL handling and error management in src/service/search/cluster/flight.rs, as both involve SQL context and schema management.

Suggested labels

🧹 Updates

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 4603b26 and 408354b.

📒 Files selected for processing (1)

src/service/search/cluster/flight.rs (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

src/service/search/cluster/flight.rs (1)

Pattern **/*.rs: You are a smart rustlang pull request reviewer.
You are going to review all the rustlang files.
Be concise, and add a brief explanation to your suggestions

Make sure the responses are not too verbose and keep the suggestions to the point i.e. actionable.

🔇 Additional comments (1)

src/service/search/cluster/flight.rs (1)

736-736: LGTM! Quoting stream names fixes the capital letter issue.

The change correctly wraps stream names in double quotes, which fixes SQL syntax issues with capital letters and will also handle special characters in stream names.

Let's verify there are no other unquoted stream names in SQL queries:

✅ Verification successful

The search results show that the unquoted identifiers found are all related to INFORMATION_SCHEMA queries, which is a standard SQL catalog that doesn't require quoting as these are fixed system table names. These findings don't represent any issues with stream name handling.

Let's verify if there are any other potential cases specifically in the search/cluster code where stream names might be used unquoted:

Stream name quoting is consistently implemented

The verification confirms that stream names are properly quoted in SQL queries throughout the codebase. The only instance found in the search/cluster code already uses proper quoting with "\"{}\"" format. The other unquoted identifiers found were standard INFORMATION_SCHEMA queries which are system tables and don't require quoting.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for SQL queries that might contain unquoted stream names
rg -U 'SELECT .+ FROM ["]*[A-Z][a-zA-Z0-9_]*[^"]'

Length of output: 1112

Script:

#!/bin/bash
# Search specifically in search/cluster directory for potential SQL queries with FROM clauses
rg -U 'FROM\s+([^"\s]+)' src/service/search/cluster/

Length of output: 153

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

hengfeiyang · 2024-11-04T09:40:56Z

ralted to #4979

fix: capital stream name can't search

408354b

github-actions bot added the ☢️ Bug Something isn't working label Nov 4, 2024

haohuaijin changed the title ~~fix: capital stream name can't search~~ fix: capital stream can't search Nov 4, 2024

haohuaijin requested a review from hengfeiyang November 4, 2024 09:12

hengfeiyang approved these changes Nov 4, 2024

View reviewed changes

hengfeiyang merged commit 773dcea into main Nov 4, 2024
26 checks passed

hengfeiyang deleted the hj/fix-search-for-capital-name branch November 4, 2024 09:39

coderabbitai bot mentioned this pull request Nov 7, 2024

feat: refactor merge file on compactor #4971

Merged

This was referenced Nov 15, 2024

feat: we can remove filter in sql when enable inverted index #5065

Merged

fix: add filter back in ingester #5111

Merged

fix: join & subquery related UI changes on logs page #5055

Merged

coderabbitai bot mentioned this pull request Dec 9, 2024

fix: merge distinct values if enable the option #5293

Merged

2 tasks

coderabbitai bot mentioned this pull request Dec 25, 2024

feat: support cross stream type join #5452

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: capital stream can't search #4978

fix: capital stream can't search #4978

Uh oh!

haohuaijin commented Nov 4, 2024 •

edited by hengfeiyang

Loading

Uh oh!

coderabbitai bot commented Nov 4, 2024 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

Uh oh!

hengfeiyang commented Nov 4, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix: capital stream can't search #4978

fix: capital stream can't search #4978

Uh oh!

Conversation

haohuaijin commented Nov 4, 2024 • edited by hengfeiyang Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Nov 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Possibly related PRs

Suggested labels

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

Uh oh!

hengfeiyang commented Nov 4, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

haohuaijin commented Nov 4, 2024 •

edited by hengfeiyang

Loading

coderabbitai bot commented Nov 4, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)