Skip to content

ci: add docker build for Pi #4964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hengfeiyang merged 1 commit into from
Nov 1, 2024
Merged

ci: add docker build for Pi #4964

hengfeiyang merged 1 commit into from
Nov 1, 2024

Conversation

@hengfeiyang
Copy link
Contributor

@hengfeiyang hengfeiyang commented Nov 1, 2024 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • New Features
    • Introduced build specification for deploying Docker images targeting ARM64 architecture.
    • Enhanced build process for improved performance and versioning.
  • Chores
    • Added configuration to manage Docker image builds and deployments.

@hengfeiyang hengfeiyang marked this pull request as draft November 1, 2024 01:52
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 1, 2024 •
edited
Loading

Caution

Review failed

The pull request is closed.

Walkthrough

A new build specification file, buildspec-tag-arm64-pi.yml, has been added to the project. This file outlines the process for deploying Docker images specifically for ARM64 architecture. It consists of two primary phases: pre_build, which handles authentication to AWS ECR Public and Docker Hub, and build, which prepares the environment by increasing swap file size, adjusting permissions, and creating a swap file. The build process also retrieves the latest Git tag and modifies a configuration file before building and pushing two versions of Docker images to AWS ECR Public.

Changes

File Change Summary
deploy/build/buildspec-tag-arm64-pi.yml Introduced a new build specification for ARM64 Docker image deployment with pre_build and build phases.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant AWS ECR
    participant Docker Hub
    participant Build Process

    User->>Build Process: Start Build
    Build Process->>Docker Hub: Log in with credentials
    Build Process->>AWS ECR: Log in with credentials
    Build Process->>Build Process: Increase swap file size
    Build Process->>Build Process: Set permissions
    Build Process->>Build Process: Create and activate swap file
    Build Process->>Git: Retrieve latest tag
    Build Process->>Config File: Modify to disable gxhash
    Build Process->>Docker: Build standard image
    Build Process->>Docker: Build debug image
    Build Process->>AWS ECR: Push standard image
    Build Process->>AWS ECR: Push debug image
Loading

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@hengfeiyang hengfeiyang marked this pull request as ready for review November 1, 2024 14:14
@hengfeiyang hengfeiyang merged commit f78d013 into main Nov 1, 2024
26 checks passed
@hengfeiyang hengfeiyang deleted the ci/arm64-pi branch November 1, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@taimingl taimingl taimingl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

✏️ Feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hengfeiyang @taimingl