.github/workflows/playwright.yml (2)

90-90: Fix formatting: Add space after comma in array.

The array items should be separated by comma and space for better readability.

-          ["sanity.spec.js", "alerts.spec.js", "schema.spec.js", "logspage.spec.js", "logsqueries.spec.js", "logsquickmode.spec.js", "multiselect-stream.spec.js", "pipeline.spec.js", "dashboardtype.spec.js", "dashboard.spec.js", "visualize.spec.js", "unflattened.spec.js","secondsPrecisionAdded.spec.js", "dashboardtanspose.spec.js"]
+          ["sanity.spec.js", "alerts.spec.js", "schema.spec.js", "logspage.spec.js", "logsqueries.spec.js", "logsquickmode.spec.js", "multiselect-stream.spec.js", "pipeline.spec.js", "dashboardtype.spec.js", "dashboard.spec.js", "visualize.spec.js", "unflattened.spec.js", "secondsPrecisionAdded.spec.js", "dashboardtanspose.spec.js"]

🧰 Tools

🪛 yamllint

[warning] 90-90: too few spaces after comma

(commas)

---

Line range hint 1-150: Consider workflow optimizations for better efficiency.

A few suggestions to improve the workflow:

1. Consider using test sharding to run tests in parallel across multiple runners
2. Add test retries for flaky tests
3. Consider caching Playwright browsers to speed up the workflow

Here's how you can implement these improvements:

  ui_integration_tests:
    name: playwright_ui_integration_tests
    needs: [build_binary]
    runs-on: 
      labels: ubuntu-latest
    container: 
      image: mcr.microsoft.com/playwright:v1.42.1-jammy
      options: --user root
    strategy:
      matrix:
        browser: [chrome]
+       # Shard tests across multiple runners
+       shardIndex: [1, 2, 3]
+       shardTotal: [3]
        testfilename: 
          ["sanity.spec.js", "alerts.spec.js", "schema.spec.js", "logspage.spec.js", "logsqueries.spec.js", "logsquickmode.spec.js", "multiselect-stream.spec.js", "pipeline.spec.js", "dashboardtype.spec.js", "dashboard.spec.js", "visualize.spec.js", "unflattened.spec.js", "secondsPrecisionAdded.spec.js", "dashboardtanspose.spec.js"]
+     # Add retry for flaky tests
+     fail-fast: false
+     max-parallel: 3

And in the test command:

-          cd tests/ui-testing && npm ci && npx playwright test ./playwright-tests/${{ matrix.testfilename }}
+          cd tests/ui-testing && npm ci && npx playwright test ./playwright-tests/${{ matrix.testfilename }} --shard=${{ matrix.shardIndex }}/${{ matrix.shardTotal }} --retries=2

🧰 Tools

🪛 yamllint

[error] 89-89: trailing spaces

(trailing-spaces)

---

[warning] 90-90: too few spaces after comma

(commas)

---

[error] 91-91: trailing spaces

(trailing-spaces)

tests/ui-testing/playwright-tests/dashboardsettings.spec.js (4)

5-6: Consider using a more readable random name generator.

The current random string might be hard to identify in test logs. Consider using a more descriptive format.

-const randomDashboardName =
-  "Dashboard_" + Math.random().toString(36).substr(2, 9);
+const randomDashboardName = `Dashboard_Test_${new Date().getTime().toString().slice(-6)}`;

---

12-12: Remove commented code.

Clean up unused commented code to improve readability.

---

81-85: Clean up commented code and improve regex documentation.

Remove commented console.log and add documentation for the regex pattern.

 function removeUTFCharacters(text) {
-  // console.log(text, "tex");
-  // Remove UTF characters using regular expression
+  // Remove non-ASCII characters to ensure compatibility
   return text.replace(/[^\x00-\x7F]/g, " ");
 }

🧰 Tools

🪛 Biome

[error] 84-84: Unexpected control character in a regular expression.

Control characters are unusual and potentially incorrect inputs, so they are disallowed.

(lint/suspicious/noControlCharactersInRegex)

---

98-104: Remove unused commented code block.

Remove the entire commented code block to improve readability.

web/src/components/dashboards/settings/GeneralSettings.vue (1)

84-84: LGTM! Well-named test attribute for save action.

The data-test attribute follows the naming convention and clearly identifies the save button for testing.

Consider adding data-test attributes to other interactive elements for comprehensive testing:

 <q-toggle
   v-model="dashboardData.showDynamicFilters"
   label="Show Dynamic Filters"
+  data-test="dashboard-general-setting-dynamic-filters"
 ></q-toggle>
 <DateTimePickerDashboard
   v-show="store.state.printMode === false"
   ref="dateTimePicker"
   class="dashboard-icons q-my-sm"
   size="sm"
   :initialTimezone="initialTimezone"
   v-model="dateTimeValue"
   :auto-apply-dashboard="true"
+  data-test="dashboard-general-setting-datetime-picker"
 />

tests/ui-testing/playwright-tests/dashboardtanspose.spec.js (1)

98-105: Remove unnecessary commented-out code

The commented-out code from lines 98 to 105 is unnecessary and should be removed to improve code readability.

tests/ui-testing/playwright-tests/unitest.spec.js (4)

2-3: Improve variable naming consistency

Consider using consistent naming conventions for imported modules. Currently, logData (camelCase) and logsdata (all lowercase) differ in casing. For clarity and to follow best practices, you might want to standardize the variable names.

---

281-282: Avoid redundant comments

The comment ////////////////////////// does not add value to the code and can be removed to improve readability.

- //////////////////////////

---

732-842: Reconsider using test.skip without a reason

There are several tests marked with test.skip without an explanation. It's helpful to provide a reason for skipping a test, so future maintainers understand the context.

For example:

test.skip("should create the specified URL using the DrillDown feature", async ({ page }) => {
  // Reason for skipping: The feature is under development.
  // Test implementation...
});

---

731-1212: Remove commented-out code

There is a significant amount of commented-out code towards the end of the file. Removing unused code can improve readability and maintainability.

Example:

- // await page.getByText('Defaultchevron_leftchevron_rightadd')).toBeVisible({ timeout: 30000 });

Configuration used: CodeRabbit UI
Review profile: CHILL

.github/workflows/playwright.yml (1)

90-90: Fix spacing after comma in test files array.

For consistency with YAML formatting standards, add a space after each comma in the array.

-          ["sanity.spec.js", "alerts.spec.js", "schema.spec.js", "logspage.spec.js", "logsqueries.spec.js", "logsquickmode.spec.js", "multiselect-stream.spec.js", "pipeline.spec.js", "dashboardtype.spec.js", "dashboard.spec.js", "visualize.spec.js", "unflattened.spec.js","secondsPrecisionAdded.spec.js", "dashboardtranspose.spec.js"]
+          ["sanity.spec.js", "alerts.spec.js", "schema.spec.js", "logspage.spec.js", "logsqueries.spec.js", "logsquickmode.spec.js", "multiselect-stream.spec.js", "pipeline.spec.js", "dashboardtype.spec.js", "dashboard.spec.js", "visualize.spec.js", "unflattened.spec.js", "secondsPrecisionAdded.spec.js", "dashboardtranspose.spec.js"]

🧰 Tools

🪛 yamllint

[warning] 90-90: too few spaces after comma

(commas)

tests/ui-testing/playwright-tests/dashboardtranspose.spec.js (3)

98-104: Remove unnecessary commented-out code

The commented-out code appears to be leftover and is not serving any purpose. Removing it will enhance code readability.

Apply this diff to clean up the code:

-// tebefore(async function () {
-//   // logData("log");
-//   // const data = page;
-//   // logData = data;
-
-//   console.log("--logData--", logData);
-// });

---

81-85: Remove unused function removeUTFCharacters

The removeUTFCharacters function is defined but not used anywhere in the code. Consider removing it to simplify the codebase.

Apply this diff to remove the unused function:

-function removeUTFCharacters(text) {
-  // console.log(text, "tex");
-  // Remove UTF characters using regular expression
-  return text.replace(/[^\x00-\x7F]/g, " ");
-}

🧰 Tools

🪛 Biome

[error] 84-84: Unexpected control character in a regular expression.

Control characters are unusual and potentially incorrect inputs, so they are disallowed.

(lint/suspicious/noControlCharactersInRegex)

---

86-97: Remove unused function applyQueryButton

The applyQueryButton function is not invoked in the code. Removing unused code helps maintain clarity.

Apply this diff to remove the function:

-async function applyQueryButton(page) {
-  // click on the run query button
-  // Type the value of a variable into an input field
-  const search = page.waitForResponse(logData.applyQuery);
-  await page.waitForTimeout(3000);
-  await page.locator("[data-test='logs-search-bar-refresh-btn']").click({
-    force: true,
-  });
-  // get the data from the search variable
-  await expect.poll(async () => (await search).status()).toBe(200);
-  // await search.hits.FIXME_should("be.an", "array");
-}

Configuration used: CodeRabbit UI
Review profile: CHILL

Configuration used: CodeRabbit UI
Review profile: CHILL

Configuration used: CodeRabbit UI
Review profile: CHILL

#!/bin/bash
# Description: Verify the runner configuration in the repository
# Check for any other workflow files using the same runner
rg -l "ubicloud-standard-8" .github/workflows/

#!/bin/bash
# Check the context of how this runner is used in other workflows
for file in $(rg -l "ubicloud-standard-8" .github/workflows/); do
  echo "=== $file ==="
  rg -B2 -A2 "ubicloud-standard-8" "$file"
done

# Also check for any documentation about custom runners
fd README.md | xargs rg -i "ubicloud|runner"

#!/bin/bash
# Description: Verify if 'logsUrl' is defined in 'logData'

# Test: Check for 'logsUrl' property in logData
ast-grep --pattern '$const logData = $_' ../cypress/fixtures/log.json | grep 'logsUrl'

#!/bin/bash
# Let's first find where logData is defined and used
rg "logData" -A 3 -B 3

# Also search for any log-related fixtures or configuration
fd "log" --type f

#!/bin/bash
# Let's check the content of the log.json file that's being imported
cat tests/ui-testing/cypress/fixtures/log.json