tests/ui-testing/playwright-tests/secondsPrecisionAdded.spec.js (4)

Line range hint 1-11: Clean up imports and remove debug code.

• Remove commented imports as they clutter the code
• Remove debug console.log statements

 import { test, expect } from '@playwright/test';
 import { LoginPage } from '../pages/loginPage.js';
 import { LogsPage } from '../pages/logsPage.js';
-//import { TracesPage } from '../pages/tracesPage.js';
-//import { ReportsPage } from '../pages/reportsPage.js';
-//import { DashboardPage } from '../pages/dashboardPage.js';
-//import { AlertPage } from '../pages/alertsPage.js';
-//import { MetricsPage } from '../pages/metricsPage.js';
 import{ startTimeValue, endTimeValue, startDateTimeValue, endDateTimeValue } from '../pages/CommonLocator.js';
-//import {CommomnLocator} from '../pages/CommonLocator'
-//console.log ('Login Started')

---

Line range hint 13-42: Improve test reliability and assertions.

Several improvements needed:

1. Replace hardcoded waitForTimeout with proper wait conditions
2. Add assertions for critical steps
3. Remove commented code

 test('Relative Seconds on Logs page', async ({ page }) => {
   const loginPage = new LoginPage(page);
   const logsPage = new LogsPage(page);
 
   await page.goto(process.env["ZO_BASE_URL"]);
   await loginPage.gotoLoginPage();
   await loginPage.login(process.env["ZO_ROOT_USER_EMAIL"], process.env["ZO_ROOT_USER_PASSWORD"]);
+  await expect(page).toHaveURL(/.*dashboard/); // Verify successful login
 
-  await page.waitForTimeout(4000);  // Wait for login process 
+  await page.waitForSelector('.logs-page', { state: 'visible' }); // Wait for logs page to be visible
   await logsPage.navigateToLogs();
 
-  await page.waitForTimeout(3000);  // Wait for logs page to load 
-  // await logsPage.selectIndexAndStream();
+  await page.waitForSelector('.time-selector', { state: 'visible' }); // Wait for time selector to be visible
   await logsPage.setTimeToPast30Seconds();
   await logsPage.verifyTimeSetTo30Seconds();
   await logsPage.signOut();
 });

---

Line range hint 44-589: Remove commented test code and maintain consistency.

1. Large blocks of commented code should be removed and tracked in version control instead
2. Time value parameters are passed inconsistently:

// Some tests use direct values
await tracesPage.fillTimeRange(startTimeValue, endTimeValue);

// While others use array syntax
await reportsPage.fillTimeRange(["startTimeValue"], ["endTimeValue"]);

3. Remove console.log statements from test code

Consider creating separate test files for each page type (e.g., logs.spec.js, traces.spec.js, etc.) instead of keeping all tests in one file. This will improve maintainability and make it easier to run specific test suites.

---

Based on the shell script results, I can now generate a final response since we have clear evidence of the test organization patterns in the codebase.

Split seconds precision tests into feature-specific files to match existing patterns

The codebase already follows a clear pattern of organizing tests by feature, with dedicated spec files for each major functionality:

• logspage.spec.js, logsqueries.spec.js, logsquickmode.spec.js for logs features
• dashboard.spec.js, dashboardtype.spec.js for dashboard features
• alerts.spec.js for alerts features
• reports.spec.js for reports features

The seconds precision tests in secondsPrecisionAdded.spec.js should be split and moved into their respective feature-specific test files to maintain consistency with the existing organization pattern. This will:

• Keep related tests together for better maintainability
• Follow the established project convention
• Make it easier to find and update time-related tests for each feature

🔗 Analysis chain

Line range hint 1-589: Verify test file organization across the codebase.

Let's check if other test files follow better organization patterns that we can adopt.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check test file organization patterns

# Find all playwright test files and their sizes
echo "Test file sizes and line counts:"
fd -e spec.js -e test.js . tests/ui-testing/playwright-tests/ -x sh -c 'echo "$(wc -l {}) ($(ls -lh {} | awk "{print \$5}"))"'

# Check for test files that might be split by feature
echo -e "\nPotential feature-specific test files:"
fd -e spec.js -e test.js . tests/ui-testing/playwright-tests/ | grep -iE '(logs|traces|metrics|dashboard|alerts|reports)'

Length of output: 2048

Configuration used: CodeRabbit UI
Review profile: CHILL