feat: improve wal file lock processing #4853

hengfeiyang · 2024-10-20T15:51:40Z

Summary by CodeRabbit

New Features
- Introduced logging for lock and release requests, improving traceability of file operations.
- Added a mechanism to track and manage files currently locked, preventing premature deletion during processing.
Bug Fixes
- Enhanced file processing logic to ensure locked files are handled appropriately, preventing errors during cleanup.

coderabbitai · 2024-10-20T15:51:48Z

Walkthrough

The changes in this pull request introduce logging functionality to the lock_request and release_request functions in src/common/infra/wal.rs, enhancing traceability of operations on WAL files. Additionally, a new static variable SKIPPED_LOCK_FILES is added in src/job/files/parquet.rs to manage files that are currently locked during processing. The prepare_files and move_files functions are modified to incorporate logic for handling locked files, ensuring they are not prematurely deleted while allowing for eventual cleanup.

Changes

File Path	Change Summary
src/common/infra/wal.rs	- Added logging to `lock_request` and `release_request` functions for traceability of actions.
src/job/files/parquet.rs	- Introduced `SKIPPED_LOCK_FILES` to track locked files.
	- Updated `prepare_files` to check and manage locked files.
	- Modified `move_files` to include a wait mechanism for locked files before deletion.

Possibly related PRs

fix: usage report duplicated #4530: Modifies the release_request function in src/common/infra/wal.rs, related to the logging enhancements in the main PR.
fix: release wal parquet files #4584: Introduces new functions in src/common/infra/wal.rs that enhance management of lock files, relevant to the logging changes in the main PR.

Suggested reviewers

oasisk
haohuaijin

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between bbb4647 and 9761587.

📒 Files selected for processing (1)

src/job/files/parquet.rs (3 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

src/job/files/parquet.rs

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 6866a2b and bbb4647.

📒 Files selected for processing (2)

src/common/infra/wal.rs (1 hunks)
src/job/files/parquet.rs (3 hunks)

🧰 Additional context used

📓 Path-based instructions (2)

src/common/infra/wal.rs (1)

Pattern **/*.rs: You are a smart rustlang pull request reviewer.
You are going to review all the rustlang files.
Be concise, and add a brief explanation to your suggestions

Make sure the responses are not too verbose and keep the suggestions to the point i.e. actionable.

src/job/files/parquet.rs (1)

Pattern **/*.rs: You are a smart rustlang pull request reviewer.
You are going to review all the rustlang files.
Be concise, and add a brief explanation to your suggestions

Make sure the responses are not too verbose and keep the suggestions to the point i.e. actionable.

🔇 Additional comments (2)

src/common/infra/wal.rs (2)

410-410: LGTM: Appropriate logging added

The added logging statement enhances the traceability of the lock_request operation. It's placed correctly at the function entry and uses an appropriate log level.

Line range hint 420-420: LGTM: Appropriate logging added

The added logging statement enhances the traceability of the release_request operation. It's placed correctly after the early return check and uses an appropriate log level.

src/job/files/parquet.rs

feat: improve wal file lock processing

bbb4647

hengfeiyang requested a review from haohuaijin October 20, 2024 15:51

hengfeiyang requested a review from oasisk October 20, 2024 15:51

github-actions bot added ✏️ Feature 🧹 Updates labels Oct 20, 2024

hengfeiyang requested a review from taimingl October 20, 2024 15:52

coderabbitai bot reviewed Oct 20, 2024

View reviewed changes

src/job/files/parquet.rs Outdated Show resolved Hide resolved

fix: spell

9761587

taimingl approved these changes Oct 20, 2024

View reviewed changes

taimingl merged commit 1418c70 into main Oct 20, 2024

taimingl deleted the fix/locking-wal branch October 20, 2024 17:59

coderabbitai bot mentioned this pull request Oct 21, 2024

fix: include exxclude search based on data type #4841

Merged

coderabbitai bot mentioned this pull request Oct 30, 2024

feat: add jobs for compact old data #4952

Merged

5 tasks

This was referenced Nov 7, 2024

feat: refactor merge file on compactor #4971

Merged

fix: parquet and index should have same row #5052

Merged

coderabbitai bot mentioned this pull request Jan 23, 2025

feat: wal file size limit & modify retry frequency and retry bug #5776

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: improve wal file lock processing #4853

feat: improve wal file lock processing #4853

Uh oh!

hengfeiyang commented Oct 20, 2024 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Oct 20, 2024 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feat: improve wal file lock processing #4853

feat: improve wal file lock processing #4853

Uh oh!

Conversation

hengfeiyang commented Oct 20, 2024 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Oct 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Possibly related PRs

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

hengfeiyang commented Oct 20, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Oct 20, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)