fix: add partial response warning #4658

oasisk · 2024-09-27T09:48:58Z

Summary by CodeRabbit

New Features
- Enhanced query handling with restrictions based on stream settings.
- Improved response messaging to indicate partial data availability.
Bug Fixes
- Adjusted query start time when exceeding maximum duration limits, ensuring compliance with stream settings.

coderabbitai · 2024-09-27T09:49:06Z

Walkthrough

The search_multi function in src/handler/http/request/search/multi_streams.rs has been updated to implement logic for managing query range restrictions based on stream settings. It now includes error handling for query durations that exceed defined limits and adjusts the query parameters accordingly. Additionally, the function has been enhanced to indicate if the response is derived from partial data and to communicate any modifications made to query parameters through error messages.

Changes

File	Change Summary
src/handler/http/request/search/multi_streams.rs	Modified `search_multi` function to handle query range restrictions, error accumulation, and response updates based on query modifications.

Possibly related PRs

fix: multi stream search panic #4101: Modifies the search_multi function to enhance data aggregation and sorting, potentially interacting with the new query range logic.
feat: multi search with multiple time ranges #4626: Focuses on improvements to request and response handling in the search_multi function, related to the new error handling and response updates.

Suggested reviewers

bjp232004
haohuaijin

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 7952243 and d87468b.

⛔ Files ignored due to path filters (1)

Cargo.lock is excluded by !**/*.lock

📒 Files selected for processing (1)

src/handler/http/request/search/multi_streams.rs (4 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

src/handler/http/request/search/multi_streams.rs (1)

Pattern **/*.rs: You are a smart rustlang pull request reviewer.
You are going to review all the rustlang files.
Be concise, and add a brief explanation to your suggestions

Make sure the responses are not too verbose and keep the suggestions to the point i.e. actionable.

🔇 Additional comments (3)

src/handler/http/request/search/multi_streams.rs (3)

168-168: LGTM!

The declaration of range_error is clear and correctly initialized.

202-218: LGTM!

The logic for enforcing the maximum query range per stream settings is correctly implemented. It adjusts the start_time when the query duration exceeds the max_query_range and accumulates a range error message.

382-390: LGTM!

The code appropriately updates multi_res to indicate when the response is based on partial data by setting is_partial to true and adjusting function_error.

src/handler/http/request/search/multi_streams.rs

oasisk added 2 commits September 27, 2024 15:00

fix: add partial response warning

4ab9795

fix

6a89bdd

github-actions bot added ☢️ Bug Something isn't working ✏️ Feature labels Sep 27, 2024

revert changes

d87468b

coderabbitai bot reviewed Sep 27, 2024

View reviewed changes

src/handler/http/request/search/multi_streams.rs Show resolved Hide resolved

ktx-abhay approved these changes Sep 27, 2024

View reviewed changes

oasisk merged commit 35d25d7 into main Sep 27, 2024

oasisk deleted the fix-add-partial-response-warning branch September 27, 2024 10:11

coderabbitai bot mentioned this pull request Sep 29, 2024

fix: multi resp changes #4662

Merged

coderabbitai bot mentioned this pull request Oct 14, 2024

feat: support partital result if some node return error #4778

Merged

coderabbitai bot mentioned this pull request Oct 30, 2024

fix: add search_type to search_multi #4955

Merged

coderabbitai bot mentioned this pull request Nov 8, 2024

feat: Integrate tantivy as an inverted index substitute #4733

Merged

7 tasks

coderabbitai bot mentioned this pull request Dec 2, 2024

feat: service accounts for api access #5212

Merged

This was referenced Dec 11, 2024

feat: websocket search & result_cache_v2 #4966

Merged

fix: cache partial responses only if its a range error #5374

Merged

This was referenced Dec 19, 2024

feat: Revamp organization #5411

Closed

feat: add grpc search endpoint #5425

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: add partial response warning #4658

fix: add partial response warning #4658

Uh oh!

oasisk commented Sep 27, 2024 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Sep 27, 2024 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix: add partial response warning #4658

fix: add partial response warning #4658

Uh oh!

Conversation

oasisk commented Sep 27, 2024 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Sep 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Possibly related PRs

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

oasisk commented Sep 27, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Sep 27, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)