Skip to content

fix: release wal parquet files #4584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
oasisk merged 2 commits into from
Sep 18, 2024
Merged

fix: release wal parquet files #4584

oasisk merged 2 commits into from
Sep 18, 2024

Conversation

@hengfeiyang
Copy link
Contributor

@hengfeiyang hengfeiyang commented Sep 18, 2024 •
edited by coderabbitai bot
Loading

fixed #4568

Summary by CodeRabbit

Summary by CodeRabbit

  • New Features

    • Introduced a method to clear and manage internal storage for file locking, enhancing resource management.
    • Added functionality to clean lock files under specific conditions when nodes are enabled or flushed.
    • Enhanced response handling for partial data in search results, providing clearer error messages to users.

  • Bug Fixes

    • Improved error handling in the search functionality to ensure resources are released properly during errors, preventing potential leaks.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 18, 2024 •
edited
Loading

Walkthrough

The changes introduce a new method clean to the SearchingFileLocker struct for clearing internal storage, alongside a public function clean_lock_files for external invocation. Additionally, the enable_node and flush_node functions are updated to call clean_lock_files() under specific conditions to manage lock files effectively. The search_parquet function is enhanced with improved error handling to ensure resources are released during error scenarios.

Changes

File Path Change Summary
src/common/infra/wal.rs Added pub fn clean(&mut self) and pub fn clean_lock_files() for managing lock files.
src/handler/http/request/status/mod.rs Updated enable_node and flush_node functions to call clean_lock_files() for resource management.
src/service/search/grpc/wal.rs Enhanced error handling in search_parquet to release resources on error during schema operations.

Assessment against linked issues

Objective Addressed Explanation
Release searching files when nodes are disabled ( #4568 ) ✅
Prevent resource leaks during error scenarios ( #4568 ) ✅

Possibly related PRs

  • fix: usage report duplicated #4530: Modifies the release_request function in the same file where the clean method was added, indicating a connection in resource management practices.
  • fix: stream status incorrect #4547: Involves changes in the context of resource management and file handling, which relates to the improvements in managing lock files introduced in the main PR.

Suggested reviewers

  • oasisk
Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between a6af8d2 and ce76c92.

Files selected for processing (4)
  • src/common/infra/wal.rs (2 hunks)
  • src/handler/http/request/search/mod.rs (1 hunks)
  • src/handler/http/request/status/mod.rs (2 hunks)
  • src/service/search/grpc/wal.rs (2 hunks)
Files skipped from review as they are similar to previous changes (4)
  • src/common/infra/wal.rs
  • src/handler/http/request/search/mod.rs
  • src/handler/http/request/status/mod.rs
  • src/service/search/grpc/wal.rs

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai generate interesting stats about this repository and render them as a table.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the ☢️ Bug Something isn't working label Sep 18, 2024
@oasisk oasisk merged commit fcb7b92 into main Sep 18, 2024
@oasisk oasisk deleted the fix/locking-wal branch September 18, 2024 12:29
This was referenced Oct 20, 2024
Merged
Merged
@coderabbitai coderabbitai bot mentioned this pull request Nov 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oasisk oasisk oasisk approved these changes

@Subhra264 Subhra264 Subhra264 approved these changes

@haohuaijin haohuaijin Awaiting requested review from haohuaijin

Assignees

No one assigned

Labels

☢️ Bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Ingestor not moving files as they are being locked for query

4 participants

@hengfeiyang @oasisk @Subhra264