Files that changed from the base of the PR and between 1397668 and a4ab4ce.

• web/src/components/DateTimePickerDashboard.vue (2 hunks)
• web/src/components/dashboards/settings/GeneralSettings.vue (5 hunks)

web/src/components/DateTimePickerDashboard.vue (2)

60-63: LGTM!

The autoApplyDashboard prop declaration is consistent with its usage in the template. The default value of false maintains the previous behavior when the prop is not set, ensuring backward compatibility.

---

19-19: Verify the usage of the autoApplyDashboard prop in the parent component.

The change enhances the flexibility of the date-time picker by allowing the auto-apply behavior to be controlled externally. However, ensure that the autoApplyDashboard prop is set appropriately in the parent component to maintain the desired user experience.

Run the following script to verify the prop usage:

Verification successful

---

The autoApplyDashboard prop is correctly implemented but not currently used by parent components.

The autoApplyDashboard prop is properly defined in the DateTimePickerDashboard.vue component with a default value of false. However, our search didn't find any instances of this prop being set by parent components. This suggests that the prop is currently used for internal purposes or prepared for future extensibility.

To improve code maintainability:

• Consider adding a comment or documentation to explain the purpose and intended use of the autoApplyDashboard prop.
• If the prop is not needed externally, you might want to consider using a local data property instead.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the usage of the `autoApplyDashboard` prop in the parent component.

# Test: Search for the prop usage. Expect: Occurrences of the prop being set.
rg --type vue -A 5 $'autoApplyDashboard='

Length of output: 68

---

Script:

#!/bin/bash
# Description: Find Vue files and search for autoApplyDashboard prop usage

# Find all .vue files and search for autoApplyDashboard prop
fd -e vue | xargs rg -n -A 5 '<DateTimePickerDashboard.*autoApplyDashboard='

# If no results, search for any occurrence of autoApplyDashboard
if [ $? -ne 0 ]; then
  echo "No direct prop usage found. Searching for any occurrence of autoApplyDashboard:"
  fd -e vue | xargs rg -n -A 5 'autoApplyDashboard'
fi

Length of output: 1223

web/src/components/dashboards/settings/GeneralSettings.vue (5)

55-55: LGTM!

Setting :auto-apply-dashboard="true" fixes the issue where the date time was not getting saved due to auto-apply being false by default. This change improves the user experience by automatically applying the dashboard settings.

---

136-136: LGTM!

Adding a comma after the route.query.dashboard argument is a formatting change that improves code consistency and readability. It does not alter the logic.

---

163-165: LGTM!

Adding commas after the route.query.dashboard and route.query.folder ?? "default" arguments is a formatting change that improves code consistency and readability. It does not alter the logic.

---

194-194: LGTM!

Adding a comma after the data argument is a formatting change that improves code consistency and readability. It does not alter the logic.

---

216-217: LGTM!

Wrapping the error message in parentheses and spreading it across two lines is a formatting change that improves code readability. It does not alter the logic.