Skip to content

fix: stream stats incorrect #4548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hengfeiyang merged 2 commits into from
Sep 14, 2024
Merged

fix: stream stats incorrect #4548

hengfeiyang merged 2 commits into from
Sep 14, 2024

Conversation

@hengfeiyang
Copy link
Contributor

@hengfeiyang hengfeiyang commented Sep 13, 2024 •
edited by coderabbitai bot
Loading

fixed #3935

If your steam stats is incorrect, please upgrade the this version and reset the stream stats once.

./openobserve reset -c stream-stats

Summary by CodeRabbit

  • New Features

    • Introduced a method to directly update stream statistics, simplifying the management of data.

  • Bug Fixes

    • Enhanced logic for handling stream statistics across various database systems, ensuring all streams are processed efficiently and correctly.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 13, 2024 •
edited
Loading

Walkthrough

The pull request modifies the StreamStats struct by replacing the add_stream_stats method with a new method called format_by, which directly updates statistics from another StreamStats instance. This change is reflected across various database handling files (mysql.rs, postgres.rs, and sqlite.rs), where the logic for managing stream statistics has been enhanced to ensure consistent processing and updating of statistics, regardless of whether the stream is new or existing.

Changes

Files Change Summary
src/config/src/meta/stream.rs Added pub fn format_by(&mut self, stats: &StreamStats) and removed pub fn add_stream_stats(&mut self, stats: &StreamStats).
src/infra/src/file_list/mysql.rs Improved logic for handling stream statistics using pattern matching for consistency in updates.
src/infra/src/file_list/postgres.rs Enhanced handling of stream statistics with pattern matching for better processing efficiency.
src/infra/src/file_list/sqlite.rs Streamlined logic for updating stream statistics with pattern matching to ensure consistency.

Assessment against linked issues

Objective Addressed Explanation
Stream stats should update after retention job completes (#3935) ✅

Possibly related PRs

  • fix: stream status incorrect #4547: This PR involves handling stream statistics, which relates directly to the new format_by method introduced in the main PR for the StreamStats struct.

Tip

OpenAI O1 model for chat
  • We have deployed OpenAI's latest O1 model for chat.
  • OpenAI claims that this model has superior reasoning capabilities than their GPT-4o model.
  • Please share any feedback with us in the discussions post.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the ☢️ Bug Something isn't working label Sep 13, 2024
coderabbitai[bot]
coderabbitai bot reviewed Sep 14, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range and nitpick comments (1)
src/config/src/meta/stream.rs (1)

308-312: Consider renaming the method and adding a doc comment to explain the behavior change.

The new format_by method directly assigns the field values from the passed StreamStats instance, overwriting the existing values. This is a change in behavior compared to the previous add_stream_stats method that aggregated the stats.

Suggestions:

  1. Consider renaming the method to something like update_from or assign_from to better convey its purpose of updating the stats from another instance.
  2. Add a doc comment explaining the behavior change from the previous add_stream_stats method to make it clear to the callers.
  3. Extract the logic for updating doc_time_min and doc_time_max into a helper method to avoid duplication with the add_file_meta method.
Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 9e27e68 and b0e69c2.

Files selected for processing (1)
  • src/config/src/meta/stream.rs (1 hunks)
Additional context used
Path-based instructions (1)
src/config/src/meta/stream.rs (1)

Pattern **/*.rs: You are a smart rustlang pull request reviewer.
You are going to review all the rustlang files.
Be concise, and add a brief explanation to your suggestions

Make sure the responses are not too verbose and keep the suggestions to the point i.e. actionable.

@hengfeiyang hengfeiyang merged commit 66ffdde into main Sep 14, 2024
@hengfeiyang hengfeiyang deleted the fix/stream-stats branch September 14, 2024 02:13
hengfeiyang added a commit that referenced this pull request Sep 17, 2024
@hengfeiyang
fix: stream stats incorrect (#4548)
dbd8655
@coderabbitai coderabbitai bot mentioned this pull request Oct 14, 2024
Merged
@coderabbitai coderabbitai bot mentioned this pull request Oct 25, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oasisk oasisk oasisk approved these changes

@prabhatsharma prabhatsharma Awaiting requested review from prabhatsharma

+1 more reviewer

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

☢️ Bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Stream Stats are not updated after retention job completes

3 participants

@hengfeiyang @oasisk