Skip to content

fix: showing not found error in preview while selecting some streams #4531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bjp232004 merged 1 commit into from
Sep 12, 2024
Merged

fix: showing not found error in preview while selecting some streams #4531

bjp232004 merged 1 commit into from
Sep 12, 2024

Conversation

@nikhilsaikethe
Copy link
Contributor

@nikhilsaikethe nikhilsaikethe commented Sep 12, 2024 •
edited by coderabbitai bot
Loading

This PR adds "" around stream name to pass any keyword that has been used as a stream name

Summary by CodeRabbit

  • Bug Fixes

    • Improved SQL query handling in the Add Alert feature to prevent syntax errors and enhance security against injection vulnerabilities.

  • Style

    • Enhanced code readability with minor formatting adjustments.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 12, 2024 •
edited
Loading

Walkthrough

The changes in the AddAlert.vue component focus on modifying SQL query strings to ensure that the stream name is properly escaped with double quotes. This adjustment is made in multiple instances where SQL queries are constructed. Additionally, a minor formatting change was introduced to enhance code readability.

Changes

File Change Summary
web/src/components/alerts/AddAlert.vue Modified SQL query strings to escape the stream name with double quotes. Added a blank line before the try block in the getParser function for improved readability.

Possibly related PRs

  • fix: added search in dropdown of clone alert #4529: This PR modifies the AlertList.vue component, which is related to alerts, similar to the changes made in AddAlert.vue. Both PRs involve enhancements to user interaction with stream names, although the specific changes differ.
Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between ada1b2d and 5ef8da0.

Files selected for processing (1)
  • web/src/components/alerts/AddAlert.vue (3 hunks)
Files skipped from review as they are similar to previous changes (1)
  • web/src/components/alerts/AddAlert.vue

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the ☢️ Bug Something isn't working label Sep 12, 2024
@bjp232004 bjp232004 merged commit 8c43214 into main Sep 12, 2024
@bjp232004 bjp232004 deleted the alert_preview__fix branch September 12, 2024 09:13
This was referenced Sep 17, 2024
Closed
Merged
@coderabbitai coderabbitai bot mentioned this pull request Oct 17, 2024
Merged
@coderabbitai coderabbitai bot mentioned this pull request Nov 5, 2024
Merged
This was referenced Nov 21, 2024
Merged
Merged
This was referenced Dec 6, 2024
Merged
Closed
Merged
Merged
This was referenced Dec 18, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bjp232004 bjp232004 bjp232004 approved these changes

@omkarK06 omkarK06 omkarK06 approved these changes

Assignees

No one assigned

Labels

☢️ Bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nikhilsaikethe @bjp232004 @omkarK06