Skip to content

fix: In create report tab options not getting set #4526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
omkarK06 merged 1 commit into from
Sep 11, 2024
Merged

fix: In create report tab options not getting set #4526

omkarK06 merged 1 commit into from
Sep 11, 2024

Conversation

@omkarK06
Copy link
Contributor

@omkarK06 omkarK06 commented Sep 11, 2024 •
edited by coderabbitai bot
Loading

#4525

Summary by CodeRabbit

  • Improvements
    • Enhanced the report creation process by ensuring folder selection is completed before proceeding, improving user experience and reducing errors.
    • Refined logic for setting dashboard and tab parameters, ensuring dependencies are respected for a more reliable report generation.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 11, 2024 •
edited
Loading

Walkthrough

The changes involve modifications to the setInitialReportData function in CreateReport.vue. Key updates include the introduction of asynchronous behavior by awaiting the completion of onFolderSelection when a folderId is present in the queryParams. Additionally, the logic for setting dashboard and tabs has been refined to ensure that their assignments depend on the presence of their respective parent parameters, enhancing the control flow of the function.

Changes

Files Change Summary
web/src/components/reports/CreateReport.vue Modified the setInitialReportData function to include asynchronous handling and refined conditional checks for setting dashboard and tabs based on parent parameters.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant CreateReport
    participant FolderSelection

    User->>CreateReport: Initiate report creation
    CreateReport->>CreateReport: Check queryParams for folderId
    alt folderId present
        CreateReport->>FolderSelection: Call onFolderSelection(folderId)
        FolderSelection-->>CreateReport: Return folder selection result
    end
    CreateReport->>CreateReport: Set dashboard and tabs based on conditions
Loading
Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 2d08716 and f36f16e.

Files selected for processing (1)
  • web/src/components/reports/CreateReport.vue (1 hunks)
Additional comments not posted (3)
web/src/components/reports/CreateReport.vue (3)

1036-1038: LGTM!

The change to await onFolderSelection when a folderId is present in the queryParams is a good improvement. It ensures the folder selection process completes before proceeding further.

1039-1041: LGTM!

The refined condition to set the dashboard only if both folderId and dashboardId are present is a good change. It improves the robustness of the code by ensuring the dependencies between the parameters are respected.

1044-1046: LGTM!

Refining the condition to set the tabs only if both dashboardId and tabId are present is a good change, similar to the previous one for dashboard. It enhances the code's robustness by respecting the dependencies between the parameters.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added ☢️ Bug Something isn't working ✏️ Feature labels Sep 11, 2024
@omkarK06 omkarK06 changed the title fix: In create report set tab options on selection of dashboard fix: Tab Options not getting set when dashboard selection details are sent via url Sep 11, 2024
@omkarK06 omkarK06 changed the title fix: Tab Options not getting set when dashboard selection details are sent via url fix: In create report tab options not getting set Sep 11, 2024
@omkarK06 omkarK06 merged commit a623954 into main Sep 11, 2024
@omkarK06 omkarK06 deleted the fix/create_report_dashboard_tab_options branch September 11, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ktx-kirtan ktx-kirtan ktx-kirtan approved these changes

Assignees

No one assigned

Labels

☢️ Bug Something isn't working ✏️ Feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@omkarK06 @ktx-kirtan