Skip to content

fix: dashboard, folder, tab on search filtering in create report #4522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
omkarK06 merged 6 commits into from
Sep 11, 2024
Merged

fix: dashboard, folder, tab on search filtering in create report #4522

omkarK06 merged 6 commits into from
Sep 11, 2024

Conversation

@omkarK06
Copy link
Contributor

@omkarK06 omkarK06 commented Sep 11, 2024 •
edited by coderabbitai bot
Loading

#4508
Search is not working for folders, dashboards, and dashboard tabs in the "Select Dashboard" option.

Summary by CodeRabbit

  • New Features

    • Improved report filtering functionality to accurately track the total number of filtered reports.
    • Enhanced handling of scheduled reports to prevent conflicts during loading states.

  • Bug Fixes

    • Fixed logic to ensure scheduled reports are properly reset, enhancing clarity and functionality.

  • Refactor

    • Simplified filtering logic for better readability and maintainability in report options.

@github-actions github-actions bot added ☢️ Bug Something isn't working ✏️ Feature labels Sep 11, 2024
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 11, 2024 •
edited
Loading

Warning

Rate limit exceeded

@omkarK06 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 4 minutes and 24 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between d67e678 and fdafc23.

Walkthrough

The pull request includes several changes across multiple Vue components, focusing on enhancing the functionality and clarity of report handling features. Key modifications involve refactoring the filtering logic in CreateReport.vue, updating the report count tracking in ScheduledDashboards.vue, and improving control flow in ViewDashboard.vue to manage loading states effectively. These changes aim to streamline the user experience and maintainability of the codebase.

Changes

File Change Summary
web/src/components/reports/CreateReport.vue Refactored onFilterOptions function to use explicit conditional checks instead of a mapping object.
web/src/views/Dashboards/ScheduledDashboards.vue Added assignment to resultTotal.value in filterReports function to track the count of filtered reports and modified rendering logic for absence of data.
web/src/views/Dashboards/ViewDashboard.vue Introduced a conditional check in openScheduledReports to prevent execution during loading and clarified resetting of scheduledReports.

Possibly related PRs

  • fix: scheduled dashboard UI issues #4510: The changes in CreateReport.vue are directly related to the main PR as both involve modifications to the same component, focusing on enhancing the functionality and clarity of report scheduling features.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@omkarK06 omkarK06 force-pushed the fix/scheduled_dashboard_fix branch from 4d4b9ef to 91fea74 Compare September 11, 2024 08:01
@omkarK06 omkarK06 merged commit 69204f6 into main Sep 11, 2024
@omkarK06 omkarK06 deleted the fix/scheduled_dashboard_fix branch September 11, 2024 09:04
@coderabbitai coderabbitai bot mentioned this pull request Oct 1, 2024
Merged
@coderabbitai coderabbitai bot mentioned this pull request Nov 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bjp232004 bjp232004 bjp232004 approved these changes

Assignees

No one assigned

Labels

☢️ Bug Something isn't working ✏️ Feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@omkarK06 @bjp232004