Skip to content

fix: use browser.wait() after browser.close() #4515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Subhra264 merged 3 commits into from
Sep 11, 2024
Merged

fix: use browser.wait() after browser.close() #4515

Subhra264 merged 3 commits into from
Sep 11, 2024

Conversation

@Subhra264
Copy link
Contributor

@Subhra264 Subhra264 commented Sep 10, 2024 •
edited by coderabbitai bot
Loading

  • After calling browser.close(), browser.wait() needs to be called to avoid various zombie processes and close the browser properly.
  • In triggers usage report, this uses cached_report as module type for destination-less reports.
  • For list reports api, filter reports based on dashboard id.

Summary by CodeRabbit

  • New Features

    • Introduced a new CachedReport variant to enhance report handling capabilities.

  • Improvements

    • Enhanced error handling and control flow in report generation to ensure browser operations complete before closure.
    • Improved logic for differentiating between cached and standard report triggers based on destination presence.

These updates aim to increase the reliability and functionality of report generation within the application.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 10, 2024 •
edited
Loading

Walkthrough

The changes include the addition of a new variant, CachedReport, to the TriggerDataType enum, enhancing its capability to handle cached report states. Modifications to the generate_report function improve error handling and control flow by adding wait operations after browser interactions. Additionally, the handle_report_triggers function now conditionally assigns the module field in the TriggerData struct based on the presence of report destinations, differentiating between cached and standard report triggers.

Changes

File Path Change Summary
src/config/src/meta/usage.rs Added CachedReport variant to TriggerDataType enum.
src/report_server/src/report.rs Enhanced error handling in generate_report by adding browser.wait().await?; after browser closure to ensure operations are complete before closing.
src/service/alerts/scheduler.rs Modified handle_report_triggers to conditionally set module in TriggerData based on report.destinations.
src/service/dashboards/reports.rs Improved generate_report function with added browser.wait().await?; after finding elements and before browser closure for better state management.
Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 263810e and 748e064.

Files selected for processing (4)
  • src/config/src/meta/usage.rs (1 hunks)
  • src/report_server/src/report.rs (3 hunks)
  • src/service/alerts/scheduler.rs (1 hunks)
  • src/service/dashboards/reports.rs (4 hunks)
Files skipped from review as they are similar to previous changes (4)
  • src/config/src/meta/usage.rs
  • src/report_server/src/report.rs
  • src/service/alerts/scheduler.rs
  • src/service/dashboards/reports.rs

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the ☢️ Bug Something isn't working label Sep 10, 2024
@Subhra264 Subhra264 force-pushed the report-server-close branch 2 times, most recently from f0c2d19 to 38a2df7 Compare September 11, 2024 04:18
@oasisk oasisk force-pushed the report-server-close branch from 38a2df7 to 4d38dc0 Compare September 11, 2024 04:41
@Subhra264 Subhra264 merged commit 69ae2c4 into main Sep 11, 2024
@Subhra264 Subhra264 deleted the report-server-close branch September 11, 2024 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hengfeiyang hengfeiyang hengfeiyang approved these changes

@oasisk oasisk oasisk approved these changes

Assignees

No one assigned

Labels

☢️ Bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Subhra264 @hengfeiyang @oasisk