Skip to content

fix: scheduled dashboard UI issues #4510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
oasisk merged 9 commits into from
Sep 10, 2024
Merged

fix: scheduled dashboard UI issues #4510

oasisk merged 9 commits into from
Sep 10, 2024

Conversation

@omkarK06
Copy link
Contributor

@omkarK06 omkarK06 commented Sep 10, 2024 •
edited
Loading

fix #4508

Summary by CodeRabbit

  • New Features

    • Enhanced report scheduling functionality with clearer options for "Schedule now" and "Schedule later."
    • Default scheduling option updated to "Schedule now."
    • Introduced filtering capability for reports based on selected tabs ("scheduled" and "cached").
    • Added sequential numbering to reports in the scheduled dashboards view.

  • Bug Fixes

    • Improved error handling during folder selection to manage issues gracefully.

  • Refactor

    • Updated data handling processes to utilize reactive references for better performance and reliability.
    • Enhanced report listing structure for improved layout and responsiveness.

  • Chores

    • Removed unnecessary console log statements to streamline functionality.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 10, 2024 •
edited
Loading

Warning

Rate limit exceeded

@omkarK06 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 7 minutes and 19 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 3220da1 and a8678f3.

Walkthrough

The pull request introduces modifications to the scheduling functionality in the CreateReport.vue component, including renaming time tab values for clarity, updating the default state of the selected time tab, and enhancing error handling. It also modifies certain functions to be asynchronous for better data handling. Enhancements in ReportList.vue improve report filtering and UI responsiveness. Additionally, ScheduledDashboards.vue includes indexing for reports, and ViewDashboard.vue ensures reactive values are used when passing parameters to the reports.list function.

Changes

File Change Summary
web/src/components/reports/CreateReport.vue Renamed time tab values; updated default selectedTimeTab; modified lifecycle hooks and functions to be asynchronous; enhanced error handling in folder selection; refactored report data initialization.
web/src/views/Dashboards/ScheduledDashboards.vue Introduced indexing for reports in the filtered output.
web/src/views/Dashboards/ViewDashboard.vue Updated parameter passing to reports.list to use reactive .value properties for folderId and dashboardId.
web/src/components/reports/ReportList.vue Added dark-mode support; improved header layout; introduced tab filtering for reports; added a static report list for filtering operations.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant CreateReport
    participant Dashboard

    User->>CreateReport: Select schedule option
    CreateReport->>CreateReport: Update selectedTimeTab
    CreateReport->>Dashboard: Call saveReport with updated values
    Dashboard->>Dashboard: Process report scheduling
    Dashboard-->>User: Display scheduled report confirmation
Loading

Possibly related PRs

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the ☢️ Bug Something isn't working label Sep 10, 2024
@omkarK06 omkarK06 force-pushed the fix/scheduled_dashboard_ui_issues branch from e501db1 to faeae3e Compare September 10, 2024 12:15
@omkarK06 omkarK06 force-pushed the fix/scheduled_dashboard_ui_issues branch from 8786dee to a8678f3 Compare September 10, 2024 12:41
@oasisk oasisk merged commit f31f09a into main Sep 10, 2024
@oasisk oasisk deleted the fix/scheduled_dashboard_ui_issues branch September 10, 2024 13:31
This was referenced Sep 11, 2024
Merged
Merged
Merged
Merged
This was referenced Sep 18, 2024
Merged
Merged
Closed
@coderabbitai coderabbitai bot mentioned this pull request Oct 1, 2024
Merged
This was referenced Oct 16, 2024
Merged
Merged
@coderabbitai coderabbitai bot mentioned this pull request Oct 28, 2024
Merged
@coderabbitai coderabbitai bot mentioned this pull request Nov 5, 2024
Merged
This was referenced Nov 12, 2024
Merged
Merged
@coderabbitai coderabbitai bot mentioned this pull request Nov 27, 2024
Merged
This was referenced Dec 5, 2024
Merged
Merged
This was referenced Dec 16, 2024
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oasisk oasisk oasisk approved these changes

Assignees

No one assigned

Labels

☢️ Bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Dashboard : Scheduled Dashboards issues.

3 participants

@omkarK06 @oasisk