Skip to content

fix: Can't enable a partition key after disable it #4507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nikhilsaikethe merged 1 commit into from
Sep 10, 2024
Merged

fix: Can't enable a partition key after disable it #4507

nikhilsaikethe merged 1 commit into from
Sep 10, 2024

Conversation

@nikhilsaikethe
Copy link
Contributor

@nikhilsaikethe nikhilsaikethe commented Sep 10, 2024 •
edited by coderabbitai bot
Loading

this PR can fix the issue with #4487

Summary by CodeRabbit

  • New Features
    • Enhanced logic for filtering keys in the stream comparison, allowing for more nuanced handling of disabled items.
  • Bug Fixes
    • Improved management of the remove array to ensure proper retention of items based on their presence in the add array.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 10, 2024 •
edited
Loading

Walkthrough

The changes in the useStreams function focus on enhancing the filtering logic for keys and managing the remove array. The previous exclusion of the "disabled" key from the filtering process has been removed, which alters how keys are compared between two objects. Additionally, the logic for determining which items to retain in the remove array has been updated to consider items present in the add array, ensuring that only items not in add and with disabled set to false are kept.

Changes

Files Change Summary
web/src/composables/useStreams.ts Enhanced filtering logic for keys and modified remove array management to consider add items.

Sequence Diagram(s)

sequenceDiagram
    participant A as Object A
    participant B as Object B
    participant R as Remove Array
    participant AD as Add Array

    A->>B: Compare keys
    A->>R: Filter keys
    alt Key is not disabled
        R->>AD: Check presence in Add
        alt Not present in Add
            R->>R: Retain key
        end
    end
Loading

Tip

Announcements
  • The review status is no longer posted as a separate comment when there are no actionable or nitpick comments. In such cases, the review status is included in the walkthrough comment.
  • We have updated our review workflow to use the Anthropic's Claude family of models. Please share any feedback in the discussion post on our Discord.
  • Possibly related PRs: Walkthrough comment now includes a list of potentially related PRs to help you recall past context. Please share any feedback in the discussion post on our Discord.
  • Suggested labels: CodeRabbit can now suggest labels by learning from your past PRs in the walkthrough comment. You can also provide custom labeling instructions in the UI or configuration file.
  • Possibly related PRs, automatic label suggestions based on past PRs, learnings, and possibly related issues require data opt-in (enabled by default).
Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 662a77b and 0867c51.

Files selected for processing (1)
  • web/src/composables/useStreams.ts (2 hunks)
Files skipped from review as they are similar to previous changes (1)
  • web/src/composables/useStreams.ts

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the ☢️ Bug Something isn't working label Sep 10, 2024
@nikhilsaikethe nikhilsaikethe merged commit b5e3772 into main Sep 10, 2024
@nikhilsaikethe nikhilsaikethe deleted the schema_settings_fix branch September 10, 2024 10:52
@coderabbitai coderabbitai bot mentioned this pull request Sep 17, 2024
Merged
@coderabbitai coderabbitai bot mentioned this pull request Oct 21, 2024
Merged
@coderabbitai coderabbitai bot mentioned this pull request Nov 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bjp232004 bjp232004 bjp232004 approved these changes

Assignees

No one assigned

Labels

☢️ Bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nikhilsaikethe @bjp232004