Skip to content

fix: dashboard cache issues #4496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ktx-abhay merged 2 commits into from
Sep 10, 2024
Merged

fix: dashboard cache issues #4496

ktx-abhay merged 2 commits into from
Sep 10, 2024

Conversation

@ktx-abhay
Copy link
Collaborator

@ktx-abhay ktx-abhay commented Sep 9, 2024 •
edited by coderabbitai bot
Loading

  • pass old selected variable values on edit panel discard/save to use cache.
  • Config showing blank on Auto mode [Dashboard cache issues #4493 ]
  • When sharing the dashboard link with an absolute time using the apply button, the shared link changes the absolute time to relative time and shows the default value [Dashboard cache issues #4493 ]

Summary by CodeRabbit

  • New Features

    • Enhanced handling of route query parameters in the Add Panel component for improved navigation and data management.
    • Introduced a reactive variable to store query parameters on component mount, ensuring they are preserved for later use.

  • Bug Fixes

    • Improved error handling in the Config Panel by implementing optional chaining to prevent runtime errors related to undefined properties.

  • Improvements

    • Refined logic for returning query parameters based on value types, enhancing clarity and functionality in the Add Panel component.
    • Added safety checks in the updateDateTime function to prevent errors when accessing the date picker.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 9, 2024 •
edited
Loading

Walkthrough

This pull request introduces changes to the ConfigPanel.vue and AddPanel.vue components. In ConfigPanel.vue, optional chaining is implemented to enhance error handling when accessing the breakdown field. In AddPanel.vue, a new reactive variable is added to store route query parameters on component mount, and modifications are made to the logic for handling these parameters and updating the date-time picker. These changes aim to improve the robustness and clarity of the component's functionality.

Changes

Files Change Summary
web/src/components/dashboards/addPanel/ConfigPanel.vue Introduced optional chaining for breakdown.length checks to enhance error handling.
web/src/views/Dashboards/addPanel/AddPanel.vue Added routeQueryParamsOnMount for storing query parameters; modified getQueryParamsForDuration and updateDateTime functions for improved handling of parameters and safety checks. Updated router navigation to use stored query parameters.

Possibly related issues

  • Dashboard cache issues #4493: The changes in AddPanel.vue regarding query parameters may help address issues related to dashboard link sharing and caching problems.

Possibly related PRs

  • feat: Scheduled Dashboards UI #4485: The changes in AddPanel.vue and the introduction of optional chaining in ConfigPanel.vue relate to enhancing user interactions and error handling in the dashboard components, which aligns with the scheduled dashboards feature aimed at improving user experience and performance.

Suggested labels

🧹 Updates

Tip

New features

Walkthrough comment now includes:

  • Possibly related PRs: A list of potentially related PRs to help you recall past context.
  • Suggested labels: CodeRabbit can now suggest labels by learning from your past PRs. You can also provide custom labeling instructions in the UI or configuration file.

Notes:

  • Please share any feedback in the discussion post on our Discord.
  • Possibly related PRs, automatic label suggestions based on past PRs, learnings, and possibly related issues require data opt-in (enabled by default).

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ktx-abhay ktx-abhay changed the title fix: pass old selected variable values on edit panel discard/save to use cache fix: dashboard cache issues Sep 9, 2024
@github-actions github-actions bot added the ☢️ Bug Something isn't working label Sep 9, 2024
coderabbitai[bot]
coderabbitai bot reviewed Sep 9, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 22ecc96 and 83d80e8.

Files selected for processing (2)
  • web/src/components/dashboards/addPanel/ConfigPanel.vue (2 hunks)
  • web/src/views/Dashboards/addPanel/AddPanel.vue (5 hunks)
Additional comments not posted (3)
web/src/components/dashboards/addPanel/ConfigPanel.vue (1)

536-536: Approved: Use of optional chaining enhances error handling.

The implementation of optional chaining (?.) in the checks for breakdown.length is a good practice. It prevents runtime errors by ensuring that these properties are accessed only if they exist, thus enhancing the robustness of the component.

Also applies to: 588-588

web/src/views/Dashboards/addPanel/AddPanel.vue (2)

431-433: Approved: Improved handling of route query parameters.

The introduction of routeQueryParamsOnMount to store the initial route query parameters on component mount is a robust enhancement. This change ensures that the original query parameters are preserved and can be reused effectively, particularly when navigating away from the component. This is crucial for maintaining state consistency across navigations.

Also applies to: 525-527

752-760: Approved: Enhanced date-time handling and parameter management.

The modifications to getQueryParamsForDuration to check data.valueType instead of data?.relativeTimePeriod refine the conditions under which the function returns query parameters, improving the clarity and accuracy of the component's functionality. Additionally, the update to updateDateTime to include a check for dateTimePickerRef?.value adds a necessary safety layer, preventing potential errors when accessing the date picker.

Also applies to: 770-778

@ktx-abhay ktx-abhay force-pushed the fix/dashboard-variable-chhange-api-call branch from 83d80e8 to 239f644 Compare September 9, 2024 17:31
coderabbitai[bot]
coderabbitai bot reviewed Sep 9, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 83d80e8 and 239f644.

Files selected for processing (2)
  • web/src/components/dashboards/addPanel/ConfigPanel.vue (2 hunks)
  • web/src/views/Dashboards/addPanel/AddPanel.vue (5 hunks)
Files skipped from review as they are similar to previous changes (2)
  • web/src/components/dashboards/addPanel/ConfigPanel.vue
  • web/src/views/Dashboards/addPanel/AddPanel.vue

@ktx-abhay ktx-abhay merged commit 2f78274 into main Sep 10, 2024
@ktx-abhay ktx-abhay deleted the fix/dashboard-variable-chhange-api-call branch September 10, 2024 04:11
This was referenced Sep 16, 2024
Merged
Merged
@coderabbitai coderabbitai bot mentioned this pull request Nov 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ktx-kirtan ktx-kirtan ktx-kirtan approved these changes

+1 more reviewer

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

☢️ Bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ktx-abhay @ktx-kirtan