Skip to content

fix: use timezone offset for cron based derived streams #4458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Subhra264 merged 1 commit into from
Sep 11, 2024
Merged

fix: use timezone offset for cron based derived streams #4458

Subhra264 merged 1 commit into from
Sep 11, 2024

Conversation

@Subhra264
Copy link
Contributor

@Subhra264 Subhra264 commented Sep 4, 2024 •
edited by coderabbitai bot
Loading

Currently for cron-based derived streams, we don't use timezone offset. Hence by default the cron expressions are assumed to be for UTC timezone. This PR sets the tz_offset field so that the cron expression works as per the browser timezone.

Summary by CodeRabbit

  • New Features

    • Enhanced routing data by including timezone offset information in the emitted data payload.

  • Bug Fixes

    • Improved data processing by integrating timezone context into the routing functionality.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 4, 2024 •
edited
Loading

Walkthrough

The changes in the StreamRouting.vue component involve the addition of a new utility function, getTimezoneOffset, imported from the zincutils module. This function is utilized within the saveRouting asynchronous function to include a new property, tz_offset, in the emitted data payload, thereby modifying the data structure to incorporate timezone information.

Changes

Files Change Summary
web/src/components/pipeline/StreamRouting.vue Added import of getTimezoneOffset and utilized it in saveRouting to include tz_offset in emitted data.
Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 7bcfffb and 31df6d2.

Files selected for processing (1)
  • web/src/components/pipeline/StreamRouting.vue (2 hunks)
Files skipped from review as they are similar to previous changes (1)
  • web/src/components/pipeline/StreamRouting.vue

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the ☢️ Bug Something isn't working label Sep 4, 2024
coderabbitai[bot]
coderabbitai bot reviewed Sep 4, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 304a0f7 and d6cac39.

Files selected for processing (1)
  • web/src/components/pipeline/StreamRouting.vue (2 hunks)
Additional comments not posted (2)
web/src/components/pipeline/StreamRouting.vue (2)

205-205: LGTM!

The import statement change is approved. The addition of the getTimezoneOffset function aligns with the PR objective of introducing timezone offset support.

509-509: Excellent work on adding the timezone offset support! 🌍⏰

The inclusion of the tz_offset property in the emitted data payload using the getTimezoneOffset function is a crucial change that directly addresses the PR objective. By providing the timezone offset information, the cron expressions can now be accurately adjusted based on the user's browser timezone, ensuring precise scheduling of tasks in the local time context.

This change enhances the usability and reliability of the cron-based derived streams feature, aligning it with the expected behavior from the user's perspective.

coderabbitai[bot]
coderabbitai bot reviewed Sep 4, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between d6cac39 and a5c56f3.

Files selected for processing (1)
  • web/src/components/pipeline/StreamRouting.vue (2 hunks)
Additional comments not posted (2)
web/src/components/pipeline/StreamRouting.vue (2)

205-205: LGTM!

The import statement change looks good. The getTimezoneOffset function is being imported from the @/utils/zincutils module, which suggests that timezone offset functionality is being introduced in the component.

509-509: LGTM!

The addition of the tz_offset property to the emitted data payload looks good. It aligns with the PR objective of introducing the tz_offset field to allow cron expressions to be adjusted based on the user's browser timezone.

To ensure the tz_offset property is being utilized correctly, please verify that the emitted data is being processed and applied to the cron expressions as intended in the backend. You can use the following script to search for the usage of the tz_offset property in the backend code:

coderabbitai[bot]
coderabbitai bot reviewed Sep 4, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between a5c56f3 and 1888ca9.

Files selected for processing (1)
  • web/src/components/pipeline/StreamRouting.vue (2 hunks)
Files skipped from review as they are similar to previous changes (1)
  • web/src/components/pipeline/StreamRouting.vue

@oasisk oasisk force-pushed the derived_stream_cron branch from 1888ca9 to 7bcfffb Compare September 11, 2024 06:48
@Subhra264 Subhra264 merged commit 348c23e into main Sep 11, 2024
@Subhra264 Subhra264 deleted the derived_stream_cron branch September 11, 2024 07:44
@coderabbitai coderabbitai bot mentioned this pull request Sep 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bjp232004 bjp232004 bjp232004 approved these changes

+1 more reviewer

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

☢️ Bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Subhra264 @bjp232004