Skip to content

fix: removed duplicated table columns #4429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
omkarK06 merged 2 commits into from
Sep 2, 2024
Merged

fix: removed duplicated table columns #4429

omkarK06 merged 2 commits into from
Sep 2, 2024

Conversation

@omkarK06
Copy link
Contributor

@omkarK06 omkarK06 commented Sep 2, 2024 •
edited by coderabbitai bot
Loading

#4426
#4427

Summary by CodeRabbit

  • New Features
    • Improved styling for "Start time" and "End time" labels in the DateTime component.
    • Enhanced field selection process in the SearchBar component to prevent duplication of fields.
  • Bug Fixes
    • Resolved issues with duplicate entries in the selected fields, improving data integrity.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 2, 2024 •
edited
Loading

Walkthrough

The changes involve updates to three components: DateTime.vue, useLogs.ts, and SearchBar.vue. The DateTime.vue component received a CSS class addition for improved styling. The useLogs.ts file modified the handling of the selectedFields variable to eliminate duplicates using a Set. Similarly, SearchBar.vue implemented logic to prevent duplication of fields in the selectedFields array when applying saved views.

Changes

File Change Summary
web/src/components/DateTime.vue Added tw-px-2 CSS class to <td> elements for "Start time" and "End time" labels.
web/src/composables/useLogs.ts Changed selectedFields declaration from const to let, introduced Set to remove duplicates.
web/src/plugins/logs/SearchBar.vue Added logic to filter out duplicates in selectedFields when applying a saved view.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant SearchBar
    participant useLogs
    participant DateTime

    User->>SearchBar: Apply saved view
    SearchBar->>useLogs: Check selectedFields
    useLogs->>useLogs: Remove duplicates using Set
    useLogs->>SearchBar: Return unique selectedFields
    SearchBar->>DateTime: Render with updated fields
Loading

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.
Early access features: disabled

We are currently testing the following features in early access:

  • Anthropic claude-3-5-sonnet for code reviews: Anthropic claims that the new Claude model has stronger code understanding and code generation capabilities than their previous models. Note: Our default code review model was also updated late last week. Please compare the quality of the reviews between the two models by toggling the early access feature.

Note:

  • You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.
  • Please join our Discord Community to provide feedback and report issues on the discussion post.

@github-actions github-actions bot added ☢️ Bug Something isn't working 🧹 Updates labels Sep 2, 2024
coderabbitai[bot]
coderabbitai bot reviewed Sep 2, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 07e2411 and 25b7a16.

Files selected for processing (3)
  • web/src/components/DateTime.vue (1 hunks)
  • web/src/composables/useLogs.ts (7 hunks)
  • web/src/plugins/logs/SearchBar.vue (1 hunks)
Files skipped from review due to trivial changes (1)
  • web/src/components/DateTime.vue
Additional comments not posted (3)
web/src/plugins/logs/SearchBar.vue (1)

1746-1752: LGTM!

The code changes to remove duplicates from selectedFields array using a Set look good. The check for existence and length of selectedFields before removing duplicates is also correct.

web/src/composables/useLogs.ts (2)

Line range hint 2931-2944: LGTM!

The code changes to remove duplicates from selectedFields using a Set before applying saved views are approved. This will prevent issues with duplicate fields.

Line range hint 2954-2965: LGTM!

The code changes to include the timestamp column in the result grid columns if it is present in selectedFields are approved. This improves consistency and ensures the timestamp is displayed when explicitly selected by the user.

@omkarK06 omkarK06 merged commit 2652329 into main Sep 2, 2024
@omkarK06 omkarK06 deleted the fix/duplicated_columns_in_saved_view branch September 2, 2024 06:25
nikhilsaikethe pushed a commit that referenced this pull request Sep 3, 2024
@omkarK06 @nikhilsaikethe
fix: removed duplicated table columns (#4429)
13a08a4 
#4426 
#4427 

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Improved styling for "Start time" and "End time" labels in the
DateTime component.
- Enhanced field selection process in the SearchBar component to prevent
duplication of fields.
- **Bug Fixes**
- Resolved issues with duplicate entries in the selected fields,
improving data integrity.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@coderabbitai coderabbitai bot mentioned this pull request Sep 27, 2024
Merged
@coderabbitai coderabbitai bot mentioned this pull request Oct 19, 2024
Merged
@coderabbitai coderabbitai bot mentioned this pull request Oct 30, 2024
Merged
This was referenced Nov 12, 2024
Closed
Merged
@coderabbitai coderabbitai bot mentioned this pull request Nov 22, 2024
Merged
@coderabbitai coderabbitai bot mentioned this pull request Dec 4, 2024
Merged
@coderabbitai coderabbitai bot mentioned this pull request Dec 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@neha00290 neha00290 neha00290 approved these changes

+1 more reviewer

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

☢️ Bug Something isn't working 🧹 Updates

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@omkarK06 @neha00290