fix: histogram will be updated when run query button will be pressed … #4112
Conversation
…or page refresh will be done
WalkthroughThe recent changes enhance the management of histogram data within the logs component by introducing a Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Index.vue
participant useLogs
User->>Index.vue: Toggle logs visualization
Index.vue->>useLogs: Set searchObj.meta.refreshHistogram = true
useLogs->>useLogs: Check refreshHistogram
useLogs-->>Index.vue: Refresh histogram data
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
…or page refresh will be done
bjp232004
force-pushed
the
4110-logs-page-pagination-back-to-1st-page
branch
from
b1777a7 to
463a662
Compare
…github.com/openobserve/openobserve into 4110-logs-page-pagination-back-to-1st-page
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- web/src/composables/useLogs.ts (4 hunks)
- web/src/plugins/logs/Index.vue (2 hunks)
Additional comments not posted (5)
web/src/plugins/logs/Index.vue (2)
518-518: LGTM! Ensures histogram refresh when logs visualization is active.This change correctly sets the
refreshHistogramproperty totrueto ensure the histogram is refreshed when the logs visualization is active.
556-556: LGTM! Ensures histogram refresh on component mount when logs visualization is active.This change correctly sets the
refreshHistogramproperty totruein theonBeforeMountlifecycle hook to ensure the histogram is refreshed when the component is mounted and the logs visualization is active.web/src/composables/useLogs.ts (3)
100-100: Addition ofrefreshHistogramproperty looks good.The
refreshHistogramproperty is correctly added to themetaobject withindefaultObjectand is set tofalseby default.
Line range hint
1674-1686:
LGTM! The logic for refreshing the histogram is correctly implemented.The
getQueryDatafunction now includes checks for therefreshHistogramproperty, ensuring that the histogram is refreshed when necessary.
3487-3487: LGTM! TherefreshHistogramproperty is correctly set totrue.The
handleRunQueryfunction now setsrefreshHistogramtotrue, ensuring that the histogram is refreshed when a new query is run.
openobserve#4112) …or page refresh will be done <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a new `refreshHistogram` property to improve histogram management within the logs component. - Enhanced the logs visualization to refresh the histogram in real-time when toggling log views. - **Bug Fixes** - Corrected conditions for refreshing the histogram to ensure data accuracy based on user interactions. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
…or page refresh will be done
Summary by CodeRabbit
New Features
refreshHistogramproperty to improve histogram management within the logs component.Bug Fixes