fix: multi stream search panic #4101

hengfeiyang · 2024-08-01T09:43:24Z

Summary by CodeRabbit

New Features
- Enhanced data aggregation and sorting in the multi-stream search functionality, improving performance and efficiency.
Bug Fixes
- Improved robustness of sorting logic by ensuring elements without timestamps do not disrupt order.

coderabbitai · 2024-08-01T09:43:33Z

Walkthrough

The recent changes enhance the search_multi function in multi_streams.rs by improving data aggregation and sorting. The method for merging results was optimized from append to extend, which streamlines the code and boosts performance. Additionally, a new check in the sorting logic ensures that elements without a _timestamp do not disrupt the overall order, making the function more robust when processing incomplete datasets.

Changes

Files	Change Summary
`src/handler/http/request/search/multi_streams.rs`	Updated `search_multi` to replace `append` with `extend` for better performance and added a conditional check in sorting to handle missing `_timestamp` keys.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant Server
    participant DataService

    Client->>Server: Initiate search_multi request
    Server->>DataService: Fetch data from multiple sources
    DataService-->>Server: Return results
    Server->>Server: Extend results into multi_res
    Server->>Server: Sort multi_res considering _timestamp
    Server-->>Client: Return aggregated and sorted results

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between db1ca05 and 4cdf024.

Files selected for processing (1)

src/handler/http/request/search/multi_streams.rs (2 hunks)

Additional context used

Path-based instructions (1)

src/handler/http/request/search/multi_streams.rs (1)

Pattern **/*.rs: You are a smart rustlang pull request reviewer.
You are going to review all the rustlang files.
Be concise, and add a brief explanation to your suggestions

Make sure the responses are not too verbose and keep the suggestions to the point i.e. actionable.

Additional comments not posted (2)

src/handler/http/request/search/multi_streams.rs (2)

314-315: Use extend for more efficient merging.

Switching from append to extend is a good optimization as it avoids the need for multiple append calls and directly merges the vectors.

359-361: Ensure robustness in sorting logic with _timestamp check.

The new conditional check for _timestamp ensures that elements without a timestamp do not disrupt the sorting order. This makes the function more robust when handling incomplete data.

bjp232004

do we need to fix _timestamp column or it should pick from configuration?

fix: multi stream search

edb477e

hengfeiyang changed the title ~~fix: multi stream search~~ fix: multi stream search panic Aug 1, 2024

github-actions bot added the ☢️ Bug Something isn't working label Aug 1, 2024

fix: multi stream search panic

4cdf024

hengfeiyang requested review from bjp232004 and haohuaijin August 1, 2024 09:45

coderabbitai bot reviewed Aug 1, 2024

View reviewed changes

haohuaijin approved these changes Aug 1, 2024

View reviewed changes

bjp232004 approved these changes Aug 1, 2024

View reviewed changes

bjp232004 reviewed Aug 1, 2024

View reviewed changes

hengfeiyang merged commit d2bfb96 into main Aug 1, 2024

hengfeiyang deleted the fix/multi-stream-search branch August 1, 2024 10:14

abvarun226 pushed a commit to abvarun226/openobserve that referenced this pull request Aug 8, 2024

fix: multi stream search panic (openobserve#4101)

eac3747

This was referenced Sep 24, 2024

feat: multi search with multiple time ranges #4626

Merged

fix: vrl for multi query range #4647

Merged

fix: add partial response warning #4658

Merged

fix: multi resp changes #4662

Merged

This was referenced Oct 7, 2024

feat: multi historical timerange evaluation for sql based alerts #4708

Merged

feat: multi time range alerts #4718

Closed

feat: Pipeline integration v2 #4732

Merged

coderabbitai bot mentioned this pull request Oct 30, 2024

fix: add search_type to search_multi #4955

Merged

coderabbitai bot mentioned this pull request Nov 8, 2024

feat: Integrate tantivy as an inverted index substitute #4733

Merged

7 tasks

coderabbitai bot mentioned this pull request Nov 19, 2024

feat: self-report for both usage and errors #5053

Merged

coderabbitai bot mentioned this pull request Dec 2, 2024

feat: service accounts for api access #5212

Merged

coderabbitai bot mentioned this pull request Dec 18, 2024

feat: websocket search & result_cache_v2 #4966

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: multi stream search panic #4101

fix: multi stream search panic #4101

Uh oh!

hengfeiyang commented Aug 1, 2024 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Aug 1, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

bjp232004 left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fix: multi stream search panic #4101

fix: multi stream search panic #4101

Uh oh!

Conversation

hengfeiyang commented Aug 1, 2024 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Aug 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

bjp232004 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

hengfeiyang commented Aug 1, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Aug 1, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)