fix: pagination part fix #4096

nikhilsaikethe · 2024-07-31T13:15:09Z

Logs count fix when moving back and forth (this was the issue that came up when I have fixed the different logs count showing at first )
Fixed another issue that onMount in histogram mode when we move to any other page and comeback to first page it shows 0 total count.

Summary by CodeRabbit

New Features
- Enhanced handling of query results for improved accuracy in data representation.
- Introduced dynamic time parameters for queries based on pagination, optimizing data retrieval.
Bug Fixes
- Addressed potential discrepancies in the total count of query results.

coderabbitai · 2024-07-31T13:15:16Z

Walkthrough

The recent modifications to the useLogs function refine how query results are managed, particularly in terms of total count and time parameters. By consistently setting the total number of query results and enabling dynamic assignment of start and end times based on pagination, these updates enhance data accuracy and improve the overall user experience when interacting with logs.

Changes

Files	Change Summary
`web/src/composables/useLogs.ts`	Revised handling of `searchObj.data.queryResults.total` and introduced dynamic time parameter setting based on pagination state.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Pagination
    participant QueryHandler
    participant Logger

    User->>Pagination: Request next page
    Pagination->>QueryHandler: Update start_time and end_time
    QueryHandler->>Logger: Fetch query results with updated time
    Logger-->>QueryHandler: Return query results
    QueryHandler-->>Pagination: Display updated results

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between db1ca05 and dbbaeb6.

Files selected for processing (1)

web/src/composables/useLogs.ts (4 hunks)

Additional comments not posted (5)

web/src/composables/useLogs.ts (5)

800-800: Ensure searchObj.data.queryResults.hits is correctly handled.

Setting searchObj.data.queryResults.hits to an empty array before updating req.query.sql ensures that previous query results do not interfere with the new query. This is a good practice to maintain data consistency.

1198-1199: Verify the initialization of searchObj.data.queryResults.total.

Setting searchObj.data.queryResults.total to 0 ensures that the total count is reset before processing new partitions. This helps avoid inaccuracies in the total count.

2247-2254: Ensure correct handling of start_time and end_time for pagination.

Setting queryReq.query.start_time and queryReq.query.end_time based on the current pagination state ensures that the histogram data is accurately retrieved for the correct time range.

2251-2254: Ensure correct handling of start_time and end_time for pagination in getQueryData.

Updating queryReq.query.start_time and queryReq.query.end_time based on the current pagination state ensures that the query data is accurately retrieved for the correct time range.

2251-2254: Ensure correct handling of start_time and end_time for pagination in getPaginatedData.

Updating queryReq.query.start_time and queryReq.query.end_time based on the current pagination state ensures that the paginated data is accurately retrieved for the correct time range.

nikhilsaikethe · 2024-08-02T13:31:48Z

Need to test it with huge data that onmounted I am appending the start time and end time so is it correct or not

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between dbbaeb6 and 489aa68.

Files selected for processing (1)

web/src/composables/useLogs.ts (4 hunks)

Files skipped from review as they are similar to previous changes (1)

web/src/composables/useLogs.ts

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 489aa68 and 7910722.

Files selected for processing (1)

web/src/composables/useLogs.ts (4 hunks)

Additional comments not posted (2)

web/src/composables/useLogs.ts (2)
2379-2386: LGTM! Verify the dynamic assignment of time parameters.

The code changes are approved.

However, ensure that the dynamic assignment of start_time and end_time for the query request works correctly in all scenarios.

Verification successful

Let's re-run the search for queryReq.query.start_time and queryReq.query.end_time without specifying the file type.

The dynamic assignment of start_time and end_time for the query request appears to be correctly implemented.

The assignments are consistent across different parts of the codebase, and no issues were found with the current implementation.

web/src/composables/useLogs.ts

web/src/plugins/traces/Index.vue
Scripts executed

The following scripts were executed for the analysis:

Script:
#!/bin/bash
# Description: Verify the dynamic assignment of `start_time` and `end_time` for the query request.

# Test: Search for the usage of `queryReq.query.start_time` and `queryReq.query.end_time` in the codebase. Expect: Ensure that the dynamic assignment works correctly in all scenarios.
rg --type javascript -A 5 $'queryReq.query.start_time'
Length of output: 88

Script:
#!/bin/bash
# Description: Verify the dynamic assignment of `start_time` and `end_time` for the query request.

# Test: Search for the usage of `queryReq.query.start_time` and `queryReq.query.end_time` in the codebase. Expect: Ensure that the dynamic assignment works correctly in all scenarios.
rg -A 5 'queryReq.query.start_time'
Length of output: 5325
1213-1214: Ensure total count logic is correct.

Setting searchObj.data.queryResults.total to 0 might impact the total count logic. Verify that this change does not cause issues with the total count calculation elsewhere in the code.

1. Logs count fix when moving back and forth (this was the issue that came up when I have fixed the different logs count showing at first ) 2. Fixed another issue that onMount in histogram mode when we move to any other page and comeback to first page it shows 0 total count.  ## Summary by CodeRabbit - **New Features** - Enhanced handling of query results for improved accuracy in data representation. - Introduced dynamic time parameters for queries based on pagination, optimizing data retrieval. - **Bug Fixes** - Addressed potential discrepancies in the total count of query results.

github-actions bot added the ☢️ Bug Something isn't working label Jul 31, 2024

coderabbitai bot reviewed Jul 31, 2024

View reviewed changes

bjp232004 force-pushed the pagination-fix branch from dbbaeb6 to 489aa68 Compare August 5, 2024 07:39

coderabbitai bot reviewed Aug 5, 2024

View reviewed changes

bjp232004 force-pushed the pagination-fix branch from 489aa68 to a75a223 Compare August 5, 2024 10:48

nikhilsaikethe added 2 commits August 5, 2024 17:32

pagination while moving front and back fixed

7652bcc

pagination issue fixed on mounted

7910722

bjp232004 force-pushed the pagination-fix branch from a75a223 to 7910722 Compare August 5, 2024 12:02

coderabbitai bot reviewed Aug 5, 2024

View reviewed changes

bjp232004 approved these changes Aug 5, 2024

View reviewed changes

bjp232004 merged commit 5724ba1 into main Aug 5, 2024

bjp232004 deleted the pagination-fix branch August 5, 2024 12:25

This was referenced Sep 24, 2024

Enterprise 0.12.1 #4637

Closed

feat: Search history introduced in the logs page #4656

Merged

fix: search history bugs fixed #4667

Merged

coderabbitai bot mentioned this pull request Oct 11, 2024

feat: O2 node sql parser implemetation #4751

Merged

This was referenced Oct 21, 2024

fix: search history seconds precision issue fixed #4863 #4864

Merged

fix: include exxclude search based on data type #4841

Merged

coderabbitai bot mentioned this pull request Oct 29, 2024

fix: issue #4935 #4940

Merged

This was referenced Nov 7, 2024

fix: fixed issue on aggregating field with non-existent alias and expand log detail #5011

Merged

fix: logs loading #5043

Closed

This was referenced Dec 9, 2024

fix: support for subquery parsing #5300

Closed

fix: 5297 subqueries not being parsed in UI #5341

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: pagination part fix #4096

fix: pagination part fix #4096

Uh oh!

nikhilsaikethe commented Jul 31, 2024 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jul 31, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

nikhilsaikethe commented Aug 2, 2024

Uh oh!

coderabbitai bot left a comment

Uh oh!

coderabbitai bot left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix: pagination part fix #4096

fix: pagination part fix #4096

Uh oh!

Conversation

nikhilsaikethe commented Jul 31, 2024 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jul 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

nikhilsaikethe commented Aug 2, 2024

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

nikhilsaikethe commented Jul 31, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 31, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)