fix: caching to consider query fn when caching #4062
Conversation
WalkthroughThe modifications to the Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant Server
participant Cache
Client->>Server: Send search request
Server->>Server: Check for VRL function
alt VRL function exists
Server->>Server: Compute hash using origin_sql + VRL function
else No VRL function
Server->>Server: Compute hash using origin_sql
end
Server->>Cache: Store computed hash
Cache-->>Server: Return cached result if available
Server-->>Client: Send response
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- src/service/search/cache/mod.rs (2 hunks)
Additional context used
Path-based instructions (1)
src/service/search/cache/mod.rs (1)
Pattern
**/*.rs: You are a smart rustlang pull request reviewer.
You are going to review all the rustlang files.
Be concise, and add a brief explanation to your suggestionsMake sure the responses are not too verbose and keep the suggestions to the point i.e. actionable.
Additional comments not posted (2)
src/service/search/cache/mod.rs (2)
76-81: Ensure proper decoding ofquery_fn.The
query_fnis being decoded usingbase64::decode_url. Ensure that thequery_fnis always URL-safe base64 encoded.
84-88: LGTM! But verify the hash computation logic.The hash computation logic now includes
query_fnif it exists. Ensure that this change does not introduce any collisions or performance issues.
<!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced query handling with improved hashing logic that incorporates an optional VRL function for better query processing and caching. - **Bug Fixes** - Improved control flow and functionality of the query handling process to ensure more accurate results based on the presence of additional input. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Summary by CodeRabbit
New Features
Bug Fixes