fix: Page count request failed will display error user will be able t… #4044
Conversation
…o see data on screen
WalkthroughThe changes enhance error management within the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- web/src/composables/useLogs.ts (6 hunks)
- web/src/plugins/logs/SearchResult.vue (1 hunks)
Additional comments not posted (5)
web/src/plugins/logs/SearchResult.vue (1)
27-33: LGTM! But verify the usage ofcountErrorMsgin the codebase.The code changes are approved. The added conditional rendering block improves user feedback by displaying error messages related to event counting.
However, ensure that
countErrorMsgis correctly set and used throughout the codebase.Verification successful
Verified: The usage of
countErrorMsgis properly set and used throughout the codebase.The
countErrorMsgis initialized and managed correctly within theuseLogs.tsfile, and it is referenced appropriately in theSearchResult.vuecomponent.
web/src/composables/useLogs.tsweb/src/plugins/logs/SearchResult.vueScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the usage of `countErrorMsg` in the codebase. # Test: Search for the usage of `countErrorMsg`. Expect: Proper setting and usage of `countErrorMsg`. rg --type python --type vue --type ts --type js 'countErrorMsg'Length of output: 94
Script:
#!/bin/bash # Description: Verify the usage of `countErrorMsg` in the codebase. # Test: Search for the usage of `countErrorMsg`. Expect: Proper setting and usage of `countErrorMsg`. rg --type vue --type ts --type js 'countErrorMsg'Length of output: 77
Script:
#!/bin/bash # Description: Verify the usage of `countErrorMsg` in the codebase. # Test: Search for the usage of `countErrorMsg`. Expect: Proper setting and usage of `countErrorMsg`. rg --type ts --type js 'countErrorMsg'Length of output: 931
web/src/composables/useLogs.ts (4)
137-137: Initialization ofcountErrorMsgindefaultObjectlooks good.This ensures that the property is always defined, preventing potential undefined errors.
372-372: ResettingcountErrorMsginresetQueryDatais appropriate.This ensures that any previous error messages related to event counting are cleared when the query data is reset.
1814-1814: ClearingcountErrorMsgingetPageCountis appropriate.This ensures that any previous error messages are removed, providing a clean state for the new query.
Line range hint
1874-1898:
SettingcountErrorMsgwith error details ingetPageCountenhances error clarity.This improves clarity by distinguishing between general error messages and those specifically related to counting events.
openobserve#4044) …o see data on screen <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced improved error message handling for the search functionality, enhancing user feedback. - Added conditional rendering in the search results to display specific error messages when applicable. - **Bug Fixes** - Resolved issues with persistent error messages across searches, ensuring previous errors do not carry over. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
2 participants
…o see data on screen
Summary by CodeRabbit
New Features
Bug Fixes