Files that changed from the base of the PR and between 93949df and 0c7376f.

• src/handler/http/request/search/mod.rs (1 hunks)
• src/handler/http/request/search/multi_streams.rs (1 hunks)
• src/service/stream.rs (1 hunks)

src/service/stream.rs (1)

82-86: LGTM!

The reassignment of s_type to StreamType::Logs if it equals StreamType::Index is correct and addresses the issue where RBAC users are unable to access the index stream.

src/handler/http/request/search/multi_streams.rs (1)

197-201: LGTM!

The reassignment of stream_type to StreamType::Logs if it equals StreamType::Index is correct and addresses the issue where RBAC users are unable to access the index stream.

src/handler/http/request/search/mod.rs (1)

217-221: LGTM! But verify the function usage in the codebase.

The code changes are approved.

However, ensure that all function calls to search correctly handle the updated stream_type logic.

Files that changed from the base of the PR and between 0c7376f and 98f0b03.

• src/common/utils/auth.rs (1 hunks)
• src/handler/http/request/stream/mod.rs (1 hunks)
• web/src/components/iam/roles/EditRole.vue (10 hunks)

• src/handler/http/request/stream/mod.rs

src/common/utils/auth.rs (1)

Line range hint 102-102:
Verify removal of StreamType::Index handling.

Ensure that the removal of StreamType::Index handling does not affect other parts of the application that might still rely on it.

web/src/components/iam/roles/EditRole.vue (2)

1459-1467: Verify the new getIndexStreams function.

Ensure that the getIndexStreams function correctly fetches and updates index streams. Compare its logic with other similar functions like getLogs, getMetrics, and getTraces.

Verification successful

---

Verification successful for the new getIndexStreams function.

The getIndexStreams function is correctly implemented and consistent with similar functions (getLogs, getMetrics, getTraces). It appropriately fetches and updates index streams as intended.

• getStreams function is defined in web/src/composables/useStreams.ts.
• updateEntityEntities function is defined and used within EditRole.vue.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the correctness of the `getIndexStreams` function.

# Test: Search for the `getIndexStreams` function and compare its logic with other similar functions.
rg --type vue 'getIndexStreams'

Length of output: 59

---

Script:

#!/bin/bash
# Description: Verify the correctness of the `getIndexStreams` function and compare its logic with other similar functions.

# Search for the `getIndexStreams` function within `.vue` files.
rg 'getIndexStreams' --glob '*.vue' -A 5

# Search for similar functions: `getLogs`, `getMetrics`, and `getTraces` within `.vue` files.
rg 'getLogs' --glob '*.vue' -A 5
rg 'getMetrics' --glob '*.vue' -A 5
rg 'getTraces' --glob '*.vue' -A 5

Length of output: 5897

---

Script:

#!/bin/bash
# Description: Verify the correctness of `getStreams` and `updateEntityEntities` functions.

# Search for the definition of `getStreams`.
rg 'function getStreams' -A 10

# Search for the definition of `updateEntityEntities`.
rg 'function updateEntityEntities' -A 10

Length of output: 75

---

Script:

#!/bin/bash
# Description: Broaden the search for the definitions or imports of `getStreams` and `updateEntityEntities`.

# Search for the definition or import of `getStreams`.
rg 'getStreams' -A 10

# Search for the definition or import of `updateEntityEntities`.
rg 'updateEntityEntities' -A 10

Length of output: 48297

---

716-717: Verify handling for "index" resource.

Ensure that the logic for handling the "index" resource is correct and aligns with the handling of other resources like "logs", "metrics", and "traces".

Verification successful

---

Verified handling for "index" resource.

The logic for handling the "index" resource in the updateRolePermissions function is consistent with the handling of other resources like "logs", "metrics", and "traces". The implementation appears correct.

• The "index" resource is included in the conditional block that handles similar resources.
• The handling involves finding the corresponding entity in the "stream" resource and calling getResourceEntities on it.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the correctness of the "index" resource handling in `updateRolePermissions`.

# Test: Search for the `updateRolePermissions` function and ensure "index" is handled similarly to other resources.
rg --type vue 'updateRolePermissions'

Length of output: 65

---

Script:

#!/bin/bash
# Description: Verify the correctness of the "index" resource handling in `updateRolePermissions`.

# Test: Search for the `updateRolePermissions` function and ensure "index" is handled similarly to other resources.
rg 'updateRolePermissions' -g '*.vue' -A 10

Length of output: 2395

---

Script:

#!/bin/bash
# Description: Extract the full implementation of the `updateRolePermissions` function from EditRole.vue for verification.

# Test: Extract the full function definition of `updateRolePermissions`.
ast-grep --lang typescript --pattern 'async function updateRolePermissions($_) { $$$ }' web/src/components/iam/roles/EditRole.vue

Length of output: 131

---

Script:

#!/bin/bash
# Description: Extract the full implementation of the `updateRolePermissions` function from EditRole.vue for verification.

# Test: Search for the `updateRolePermissions` function and include 50 lines of context to capture the full implementation.
rg 'async function updateRolePermissions' web/src/components/iam/roles/EditRole.vue -A 50

Length of output: 91

---

Script:

#!/bin/bash
# Description: Extract the full implementation of the `updateRolePermissions` function from EditRole.vue for verification.

# Test: Search for the `updateRolePermissions` function and include 100 lines of context to ensure capturing the full implementation.
rg 'const updateRolePermissions = async' web/src/components/iam/roles/EditRole.vue -A 100

Length of output: 3064