fix: add searchtype params to dashboard url for reports #3670

Subhra264 · 2024-06-03T15:16:37Z

Summary by CodeRabbit

New Features
- Enhanced report URLs with a searchtype=reports parameter for better categorization and filtering of reports.

coderabbitai · 2024-06-03T15:16:45Z

Walkthrough

The recent updates to the generate_report function in both src/report_server/src/report.rs and src/service/dashboards/reports.rs involve the addition of a searchtype=reports parameter to the URLs generated for dashboards. This parameter is included for both relative and absolute timerange types, ensuring that all generated report URLs now explicitly indicate they are for report searches.

Changes

Files	Change Summary
`src/report_server/src/report.rs`	Updated `generate_report` function to include `searchtype=reports` parameter in URLs for both timerange types.
`src/service/dashboards/reports.rs`	Updated `generate_report` function to include `searchtype=reports` parameter in URLs for both timerange types.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 2d530eb and 77e75ae.

Files selected for processing (2)

src/report_server/src/report.rs (2 hunks)
src/service/dashboards/reports.rs (2 hunks)

Additional context used

Path-based instructions (2)

src/report_server/src/report.rs (1)

Pattern **/*.rs: You are a smart rustlang pull request reviewer.
You are going to review all the rustlang files.
Be concise, and add a brief explanation to your suggestions

Make sure the responses are not too verbose and keep the suggestions to the point i.e. actionable.

src/service/dashboards/reports.rs (1)

Pattern **/*.rs: You are a smart rustlang pull request reviewer.
You are going to review all the rustlang files.
Be concise, and add a brief explanation to your suggestions

Make sure the responses are not too verbose and keep the suggestions to the point i.e. actionable.

Additional comments not posted (2)

src/report_server/src/report.rs (1)

212-212: The addition of searchtype=reports to the URLs is correctly implemented and aligns with the PR objectives.

Also applies to: 263-263

src/service/dashboards/reports.rs (1)

439-439: The addition of searchtype=reports to the URLs is correctly implemented and aligns with the PR objectives.

Also applies to: 489-489

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 77e75ae and 5dbeac6.

Files selected for processing (2)

src/report_server/src/report.rs (2 hunks)
src/service/dashboards/reports.rs (2 hunks)

Files skipped from review as they are similar to previous changes (2)

src/report_server/src/report.rs
src/service/dashboards/reports.rs

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 5dbeac6 and 6319ea5.

Files selected for processing (2)

src/report_server/src/report.rs (2 hunks)
src/service/dashboards/reports.rs (2 hunks)

Files skipped from review as they are similar to previous changes (2)

src/report_server/src/report.rs
src/service/dashboards/reports.rs

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 6319ea5 and 7aba642.

Files selected for processing (2)

src/report_server/src/report.rs (2 hunks)
src/service/dashboards/reports.rs (2 hunks)

Files skipped from review as they are similar to previous changes (2)

src/report_server/src/report.rs
src/service/dashboards/reports.rs

## Summary by CodeRabbit - **New Features** - Enhanced report URLs with a `searchtype=reports` parameter for better categorization and filtering of reports.

github-actions bot added ☢️ Bug Something isn't working ✏️ Feature labels Jun 3, 2024

Subhra264 force-pushed the report_search_type branch from bc839a5 to 77e75ae Compare June 3, 2024 15:17

coderabbitai bot reviewed Jun 3, 2024

View reviewed changes

Subhra264 force-pushed the report_search_type branch from 77e75ae to 5dbeac6 Compare June 4, 2024 12:23

coderabbitai bot reviewed Jun 4, 2024

View reviewed changes

Subhra264 force-pushed the report_search_type branch from 5dbeac6 to 6319ea5 Compare June 5, 2024 05:15

ktx-abhay approved these changes Jun 5, 2024

View reviewed changes

coderabbitai bot reviewed Jun 5, 2024

View reviewed changes

fix: add searchtype params to dashboard url for reports

7aba642

Subhra264 force-pushed the report_search_type branch from 6319ea5 to 7aba642 Compare June 5, 2024 09:17

coderabbitai bot reviewed Jun 5, 2024

View reviewed changes

Subhra264 merged commit 59ed7ce into main Jun 5, 2024

Subhra264 deleted the report_search_type branch June 5, 2024 12:07

coderabbitai bot mentioned this pull request Oct 28, 2024

feat: SearchEventContext for search usage reports #4934

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: add searchtype params to dashboard url for reports #3670

fix: add searchtype params to dashboard url for reports #3670

Uh oh!

Subhra264 commented Jun 3, 2024 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jun 3, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

coderabbitai bot left a comment

Uh oh!

coderabbitai bot left a comment

Uh oh!

coderabbitai bot left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix: add searchtype params to dashboard url for reports #3670

fix: add searchtype params to dashboard url for reports #3670

Uh oh!

Conversation

Subhra264 commented Jun 3, 2024 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jun 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Subhra264 commented Jun 3, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jun 3, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)