-
Notifications
You must be signed in to change notification settings - Fork 715
fix: removed partition api while aggregation query #3647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Warning Rate limit exceeded@bjp232004 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 41 minutes and 23 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThe recent changes primarily enhance error handling and logic restructuring in the Changes
Sequence Diagram(s) (Beta)sequenceDiagram
participant User
participant SearchResultComponent
participant UseLogsComposable
participant Database
User->>SearchResultComponent: Initiates log search
SearchResultComponent->>UseLogsComposable: Calls getQueryPartitions
UseLogsComposable->>UseLogsComposable: Parse SQL and apply error handling (try-catch)
alt sqlMode and isNonAggregatedQuery
UseLogsComposable->>Database: Query for non-aggregated data
else sqlMode only
UseLogsComposable->>Database: Query for aggregated data
end
UseLogsComposable->>UseLogsComposable: Process partitions and pagination data
UseLogsComposable->>SearchResultComponent: Return query results
SearchResultComponent->>User: Display results with adjusted height
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range and nitpick comments (2)
web/src/composables/useLogs.ts (2)
Line range hint
837-1007: RefactorgetQueryPartitionsfor better readability and maintainability.The
getQueryPartitionsfunction is quite lengthy and handles multiple responsibilities, which makes it hard to read and maintain. Consider breaking it down into smaller, more focused functions. For example, handling the partition query request and processing the response could be separated into different functions.
Line range hint
128-128: Replaceanytype with more specific types.Using
anytype can lead to potential bugs and makes the code less maintainable and harder to understand. Where possible, replaceanywith more specific types to improve type safety and code clarity.Also applies to: 129-129, 139-139, 143-143, 146-146, 151-151, 153-153, 154-154, 155-155, 156-156, 157-157, 169-169, 170-170, 175-175, 176-176, 186-186, 187-187, 228-228, 240-240, 241-241
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- web/src/composables/useLogs.ts (2 hunks)
Additional context used
Biome
web/src/composables/useLogs.ts
[error] 128-128: Unexpected any. Specify a different type.
[error] 129-129: Unexpected any. Specify a different type.
[error] 139-139: Unexpected any. Specify a different type.
[error] 143-143: Unexpected any. Specify a different type.
[error] 146-146: Unexpected any. Specify a different type.
[error] 151-151: Unexpected any. Specify a different type.
[error] 153-153: Unexpected any. Specify a different type.
[error] 154-154: Unexpected any. Specify a different type.
[error] 155-155: Unexpected any. Specify a different type.
[error] 156-156: Unexpected any. Specify a different type.
[error] 157-157: Unexpected any. Specify a different type.
[error] 169-169: Unexpected any. Specify a different type.
[error] 170-170: Unexpected any. Specify a different type.
[error] 175-175: Unexpected any. Specify a different type.
[error] 176-176: Unexpected any. Specify a different type.
[error] 186-186: Unexpected any. Specify a different type.
[error] 187-187: Unexpected any. Specify a different type.
[error] 228-228: Unexpected any. Specify a different type.
[error] 240-240: Unexpected any. Specify a different type.
[error] 241-241: Unexpected any. Specify a different type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range and nitpick comments (2)
web/src/composables/useLogs.ts (2)
Line range hint
837-1007: RefactorgetQueryPartitionsfor clarity and efficiency.The
getQueryPartitionsfunction is quite large and handles multiple responsibilities, which makes it hard to understand and maintain. Consider breaking it down into smaller, more focused functions. Additionally, the nested conditionals and loops could be simplified or extracted to improve readability and reduce complexity.
Line range hint
128-128: Specify explicit types instead ofany.Using
anytype defeats the purpose of TypeScript's static type checking. Where possible, replaceanywith more specific types to improve code safety and clarity. Here are some lines that need attention:
- Line 128: Define a specific type for
parser.- Line 129: Define a specific type for
fieldValues.- Line 139: Define a specific type for
initialQueryPayload.- Line 143: Define a specific type for
notificationMsg.- Line 146: Define a specific type for
searchObj.- Line 151: Define a specific type for
searchObjDebug.- Line 153: Define a specific type for
searchAggData.- Line 154: Define a specific type for
useLogs.- Line 155: Define a specific type for
useNotifications.- Line 156: Define a specific type for
useStreams.- Line 157: Define a specific type for
searchService.- Line 169: Define a specific type for
LogsQueryPayload.- Line 170: Define a specific type for
savedviewsService.- Line 175: Define a specific type for
config.- Line 176: Define a specific type for
defaultObject.- Line 186: Define a specific type for
searchObj.- Line 187: Define a specific type for
searchObjDebug.- Line 228: Define a specific type for
parser.- Line 240: Define a specific type for
fieldValues.- Line 241: Define a specific type for
initialQueryPayload.Also applies to: 129-129, 139-139, 143-143, 146-146, 151-151, 153-153, 154-154, 155-155, 156-156, 157-157, 169-169, 170-170, 175-175, 176-176, 186-186, 187-187, 228-228, 240-240, 241-241
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- web/src/composables/useLogs.ts (2 hunks)
Additional context used
Biome
web/src/composables/useLogs.ts
[error] 128-128: Unexpected any. Specify a different type.
[error] 129-129: Unexpected any. Specify a different type.
[error] 139-139: Unexpected any. Specify a different type.
[error] 143-143: Unexpected any. Specify a different type.
[error] 146-146: Unexpected any. Specify a different type.
[error] 151-151: Unexpected any. Specify a different type.
[error] 153-153: Unexpected any. Specify a different type.
[error] 154-154: Unexpected any. Specify a different type.
[error] 155-155: Unexpected any. Specify a different type.
[error] 156-156: Unexpected any. Specify a different type.
[error] 157-157: Unexpected any. Specify a different type.
[error] 169-169: Unexpected any. Specify a different type.
[error] 170-170: Unexpected any. Specify a different type.
[error] 175-175: Unexpected any. Specify a different type.
[error] 176-176: Unexpected any. Specify a different type.
[error] 186-186: Unexpected any. Specify a different type.
[error] 187-187: Unexpected any. Specify a different type.
[error] 228-228: Unexpected any. Specify a different type.
[error] 240-240: Unexpected any. Specify a different type.
[error] 241-241: Unexpected any. Specify a different type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Outside diff range and nitpick comments (3)
web/src/composables/useLogs.ts (3)
Line range hint
837-1014: RefactorgetQueryPartitionsfor clarity and error handling.The
getQueryPartitionsfunction is quite lengthy and handles multiple concerns, which makes it hard to follow and maintain. Consider breaking it down into smaller, more focused functions. Additionally, the error handling could be improved by ensuring that all potential error paths are covered and that errors are logged or handled appropriately.
Line range hint
128-128: Replaceanytype with specific types to enhance type safety.Using
anytype in TypeScript can lead to potential runtime errors due to lack of type checking. Where possible, replaceanywith more specific types to improve code safety and clarity. For example, if a variable is expected to hold a string, usestringinstead ofany.Also applies to: 129-129, 139-139, 143-143, 146-146, 151-151, 153-153, 154-154, 155-155, 156-156, 157-157, 169-169, 170-170, 175-175, 176-176, 186-186, 187-187, 228-228, 240-240, 241-241
Line range hint
1-1014: Consider modularizing theuseLogscomposable.The
useLogscomposable is very large and handles multiple responsibilities. Consider breaking it down into smaller, more focused composables or utilities. This can improve readability, maintainability, and testability of the code.
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- web/src/composables/useLogs.ts (2 hunks)
- web/src/plugins/logs/SearchResult.vue (1 hunks)
Additional context used
Biome
web/src/composables/useLogs.ts
[error] 128-128: Unexpected any. Specify a different type.
[error] 129-129: Unexpected any. Specify a different type.
[error] 139-139: Unexpected any. Specify a different type.
[error] 143-143: Unexpected any. Specify a different type.
[error] 146-146: Unexpected any. Specify a different type.
[error] 151-151: Unexpected any. Specify a different type.
[error] 153-153: Unexpected any. Specify a different type.
[error] 154-154: Unexpected any. Specify a different type.
[error] 155-155: Unexpected any. Specify a different type.
[error] 156-156: Unexpected any. Specify a different type.
[error] 157-157: Unexpected any. Specify a different type.
[error] 169-169: Unexpected any. Specify a different type.
[error] 170-170: Unexpected any. Specify a different type.
[error] 175-175: Unexpected any. Specify a different type.
[error] 176-176: Unexpected any. Specify a different type.
[error] 186-186: Unexpected any. Specify a different type.
[error] 187-187: Unexpected any. Specify a different type.
[error] 228-228: Unexpected any. Specify a different type.
[error] 240-240: Unexpected any. Specify a different type.
[error] 241-241: Unexpected any. Specify a different type.
<!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Enhanced error handling in the log querying process to improve stability. - Adjusted height calculations in search results for better display based on user settings. - **Improvements** - Restructured query logic for better performance and accuracy. - Improved processing of partitions and pagination for more efficient data handling. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Summary by CodeRabbit
Bug Fixes
Improvements