Skip to content

Conversation

@epretti
Copy link
Member

@epretti epretti commented Aug 5, 2025

Fixes #396; see #391 for context. This class is broken and currently untested, so no changes other than removing it should be necessary here.

@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.16%. Comparing base (e7c1f9e) to head (7994d19).
⚠️ Report is 3 commits behind head on main.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #397      +/-   ##
==========================================
+ Coverage   81.09%   83.16%   +2.07%     
==========================================
  Files           5        5              
  Lines         825      802      -23     
==========================================
- Hits          669      667       -2     
+ Misses        156      135      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@epretti
Copy link
Member Author

epretti commented Aug 5, 2025

There are some unusual errors that appear to be associated with espaloma and unrelated to this change: I will try to figure out what's happening.

@mattwthompson
Copy link
Collaborator

With #398 merged in, this is hopefully good to go

The next domino would be #391?

@epretti epretti enabled auto-merge August 6, 2025 16:08
@epretti epretti merged commit 6f372f0 into openmm:main Aug 6, 2025
14 checks passed
@epretti epretti deleted the remove-dummysystemgenerator branch August 6, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove DummySystemGenerator

4 participants